Reebable skipped tests (#3708)

dart-lang · May 21, 2024 · e67cdd5 · e67cdd5
1 parent 6e381e7
commit e67cdd5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/_test/test/help_test.dart b/_test/test/help_test.dart
@@ -54,8 +54,7 @@ Future<void> _testHelpCommand(List<String> args, {String? checkContent}) async {
   expect(result.exitCode, equals(0),
       reason: 'should give a successful exit code');
   expect(result.stderr, isEmpty,
-      reason: 'Should output nothing on stderr',
-      skip: 'https://github.com/dart-lang/sdk/issues/50592');
+      reason: 'Should output nothing on stderr',);
   expect(result.stdout, isNot(contains('"Unhandled exception"')),
       reason: 'Should not print an unhandled exception');
   if (checkContent != null) {

diff --git a/build_runner/test/build_script_generate/build_script_generate_test.dart b/build_runner/test/build_script_generate/build_script_generate_test.dart
@@ -37,8 +37,7 @@ builders:
         ]).create();
 
         var result = await runPub('a', 'run', args: ['build_runner', 'build']);
-        expect(result.stderr, isEmpty,
-            skip: 'https://github.com/dart-lang/sdk/issues/50592');
+        expect(result.stderr, isEmpty);
         expect(
             result.stdout,
             contains(
@@ -57,8 +56,7 @@ builders:
         ]).create();
 
         var result = await runPub('a', 'run', args: ['build_runner', 'build']);
-        expect(result.stderr, isEmpty,
-            skip: 'https://github.com/dart-lang/sdk/issues/50592');
+        expect(result.stderr, isEmpty);
         expect(
             result.stdout,
             isNot(contains(
@@ -87,8 +85,7 @@ builders:
 ''')
         ]).create();
         var result = await runPub('a', 'run', args: ['build_runner', 'build']);
-        expect(result.stderr, isEmpty,
-            skip: 'https://github.com/dart-lang/sdk/issues/50592');
+        expect(result.stderr, isEmpty);
         expect(result.stdout, contains('could not be parsed'));
       });
 
@@ -103,8 +100,7 @@ builders:
 ''')
         ]).create();
         var result = await runPub('a', 'run', args: ['build_runner', 'build']);
-        expect(result.stderr, isEmpty,
-            skip: 'https://github.com/dart-lang/sdk/issues/50592');
+        expect(result.stderr, isEmpty);
         expect(
             result.stdout,
             contains('Could not load imported package "unknown_package" '
@@ -123,8 +119,7 @@ global_options:
       ]).create();
 
       var result = await runPub('a', 'run', args: ['build_runner', 'build']);
-      expect(result.stderr, isEmpty,
-          skip: 'https://github.com/dart-lang/sdk/issues/50592');
+      expect(result.stderr, isEmpty);
       expect(
           result.stdout,
           allOf(