expose librariesPath in DevCompilerBuilder #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Aug 12, 2019
jakemac53
approved these changes
Aug 12, 2019
|
Looks like maybe there was a new sdk with new lints - or maybe the an existing lint was updated to catch more cases. I will work on getting things green at head then we can land this. |
|
Sounds good, just give me a heads up when/if you merge this. |
|
#2405 is the fix cl |
|
Hmm looks like we have other failures too with the latest dev. If I can't get it green today we can merge on red. |
|
Got it to the point where all the tests at least ran and were green (other than the one expected failure), so merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only change required to resolve import issues with package:http. Mirrors the way libraries was exposed from the kernel builder.
flutter/flutter#34858