Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resolve(id) to BuildStep #25

Merged
merged 1 commit into from
Feb 3, 2016
Merged

add resolve(id) to BuildStep #25

merged 1 commit into from
Feb 3, 2016

Conversation

jakemac53
Copy link
Contributor

This adds essentially the code_transformers package logic directly to this package. It is up in the air still if this is really a good idea or not though ;).

cc @munificent @nex3

closes #24

// BSD-style license that can be found in the LICENSE file.
import 'dart:async';

import 'package:analyzer/src/generated/ast.dart' show Expression;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the "visible" import package:analyzer/analyzer.dart instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jakemac53
Copy link
Contributor Author

updated

@kegluneq
Copy link

kegluneq commented Feb 3, 2016

For future reviews, please push a commit with just review changes overtop the original one. You can always merge them before committing.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easy and fast to use the analyzer
3 participants