-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add caching of assets #29
Conversation
5cfe3fa
to
ca883d5
Compare
reassigned, for some reason I thought Tim was not around |
ca883d5
to
765f90e
Compare
@@ -13,5 +13,10 @@ class Asset { | |||
|
|||
Asset(this.id, this.stringContents); | |||
|
|||
bool operator ==(other) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please override hashCode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually just going to make this a test only utility, thats all I was using it for.
updated |
LGTM |
8415c13
to
241c41c
Compare
closes #23