Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caching of assets #29

Merged
merged 1 commit into from
Feb 4, 2016
Merged

add caching of assets #29

merged 1 commit into from
Feb 4, 2016

Conversation

jakemac53
Copy link
Contributor

closes #23

@jakemac53
Copy link
Contributor Author

reassigned, for some reason I thought Tim was not around

@@ -13,5 +13,10 @@ class Asset {

Asset(this.id, this.stringContents);

bool operator ==(other) =>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please override hashCode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually just going to make this a test only utility, thats all I was using it for.

@jakemac53
Copy link
Contributor Author

updated

@kegluneq
Copy link

kegluneq commented Feb 4, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generalized caching layer for Assets
4 participants