Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyzer to 1.0.0. #3003

Merged
merged 30 commits into from
Feb 16, 2021
Merged

Conversation

jcollins-g
Copy link
Contributor

This sets the minimum constraint for analyzer on relevant packages to 1.0.0, and deals with the source_gen problem by commenting out json_serializable.

Also switches testing back to the dev branch, as this will now work with the new analyzer.

@google-cla google-cla bot added the cla: yes Google is happy with the PR contributors label Feb 12, 2021
@@ -1,3 +1,7 @@
## 1.5.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 1.5.4
## 1.5.4-dev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jakemac53
Copy link
Contributor

@jcollins-g looks like we need another override on build_config in the test at build_runner/test/generate/run_script_test.dart

@jcollins-g
Copy link
Contributor Author

@jakemac53 yep, just figured that out myself. Trying again. Oddly enough, the problem won't reproduce locally.

@jakemac53
Copy link
Contributor

@jakemac53 yep, just figured that out myself. Trying again. Oddly enough, the problem won't reproduce locally.

I think these tests don't run by default locally, they are tagged as "integration" tests and we exclude those by default locally as they take forever to run, you can do -t integration to run them.

@jcollins-g
Copy link
Contributor Author

@jakemac53 yep, just figured that out myself. Trying again. Oddly enough, the problem won't reproduce locally.

I think these tests don't run by default locally, they are tagged as "integration" tests and we exclude those by default locally as they take forever to run, you can do -t integration to run them.

No, I was running them, just couldn't reproduce the problem.

@jcollins-g
Copy link
Contributor Author

If this does manage to pass, the PR should be mergeable. PTAL.

@jcollins-g
Copy link
Contributor Author

merging per offline discussion

@jcollins-g jcollins-g merged commit 86a384f into dart-lang:master Feb 16, 2021
@jcollins-g jcollins-g deleted the glob200+analyzer branch February 16, 2021 23:57
jakemac53 pushed a commit that referenced this pull request Feb 17, 2021
The following packages will need to be published in order to get #3003 into the ecosystem:

```
build
build_config
build_daemon
build_modules
build_resolvers
build_runner
build_runner_core
build_test
build_vm_compilers
build_web_compilers
```

This PR adjusts the changelogs and version numbers to remove the `-dev` and so, get it ready to publish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants