Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK in old release of build_modules #3442

Closed
wants to merge 1 commit into from

Conversation

natebosch
Copy link
Member

@natebosch natebosch commented Jan 26, 2023

Closes dart-lang/sdk#51128

SDK version 2.19.0 introduces a static error that was missing from earlier SDK versions. Upgrading to language version 2.18 or greater brings a language change with improved inference which resolves the issue. Upgrade to 2.19.0 so that the backported change impacts the fewest users possible.

Closes #51128

SDK version `2.19.0` introduces a static error that was missing from
earlier SDK versions. Upgrading to language version `2.18` or greater
brings a language change with improved inference which resolves the
issue. Upgrade to `2.19.0` so that the backported change impacts the
fewest users possible.
@natebosch
Copy link
Member Author

My plan is to wait for approval, publish from this commit, resolve conflicts with a merge from master, then merge this PR to master with a merge commit. I'll have to temporarily enable merge commits - any concerns with that @kevmoo ?

@kevmoo
Copy link
Member

kevmoo commented Jan 26, 2023

@natebosch – SGTM!

@natebosch
Copy link
Member Author

@jodinathan do I understand correctly that you found another solution to this?

Would it still be useful to have a 2.19.0 compatible version of build_modules version 4.0.6 published, or can we close this?

@jodinathan
Copy link

yes you can @natebosch.

We just migrated angular to analyzer 5 using ngdart (thanks to the community heroic effort) as base and the test were successful. So this issue isn't blocking us from upgrading to 2.19 anymore.

It has been years and you guys are the same incredible as before. Thanks for the help!

@natebosch natebosch closed this Jan 26, 2023
@natebosch natebosch deleted the build-module-4.0.6-backports branch January 26, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't serve web project with 2.19
4 participants