Skip to content

Conversation

@natebosch
Copy link
Member

When sorting the builder definitions in topological order based on their
builder dependency conversation, also apply a secondary sort based on
the alpha sort of their keys. This turns what would be an arbitrary and
potentially changing ordering into an arbitrary, but consistent
ordering.

See discussion at dart-archive/graphs#86

When sorting the builder definitions in topological order based on their
builder dependency conversation, also apply a secondary sort based on
the alpha sort of their keys. This turns what would be an arbitrary and
potentially changing ordering into an arbitrary, but consistent
ordering.

See discussion at dart-archive/graphs#86
@natebosch natebosch requested a review from jakemac53 May 12, 2023 23:30
Co-authored-by: Jacob MacDonald <jakemac@google.com>
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go ahead and publish this too? Does it fix some of the known issues people have had?

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go ahead and publish this too? Does it fix some of the known issues people have had?

@natebosch
Copy link
Member Author

natebosch commented May 12, 2023

Does it fix some of the known issues people have had?

That's hard to say - it probably has an equal chance of fixing issues, or causing entirely new ones.
What it will do is nail down the ordering so that this is the last time this can come up - and once folks fix ordering issues with this release we can be confident they won't have to do it again.

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:build_runner 2.4.4 ready to publish build_runner-v2.4.4
package:build_web_compilers 4.0.4-wip version 4.0.4-wip is pre-release; no publish necessary
package:build 2.4.1-wip version 2.4.1-wip is pre-release; no publish necessary
package:scratch_space 1.0.2 already published at pub.dev
package:build_modules 5.0.3-wip version 5.0.3-wip is pre-release; no publish necessary
package:build_daemon 4.0.1-dev version 4.0.1-dev is pre-release; no publish necessary
package:build_runner_core 7.2.9-wip version 7.2.9-wip is pre-release; no publish necessary
package:build_test 2.2.0-wip version 2.2.0-wip is pre-release; no publish necessary
package:build_resolvers 2.2.1-wip version 2.2.1-wip is pre-release; no publish necessary
package:build_config 1.1.2-dev version 1.1.2-dev is pre-release; no publish necessary

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants