-
Notifications
You must be signed in to change notification settings - Fork 221
Use topologicalSort with a secondary sort #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When sorting the builder definitions in topological order based on their builder dependency conversation, also apply a secondary sort based on the alpha sort of their keys. This turns what would be an arbitrary and potentially changing ordering into an arbitrary, but consistent ordering. See discussion at dart-archive/graphs#86
Co-authored-by: Jacob MacDonald <jakemac@google.com>
jakemac53
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go ahead and publish this too? Does it fix some of the known issues people have had?
jakemac53
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go ahead and publish this too? Does it fix some of the known issues people have had?
That's hard to say - it probably has an equal chance of fixing issues, or causing entirely new ones. |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
When sorting the builder definitions in topological order based on their
builder dependency conversation, also apply a secondary sort based on
the alpha sort of their keys. This turns what would be an arbitrary and
potentially changing ordering into an arbitrary, but consistent
ordering.
See discussion at dart-archive/graphs#86