Update package:frontend_server_client constraint to >=3.0.0 <5.0.0 #3662
Conversation
build_runner/pubspec.yaml
Outdated
| @@ -24,7 +24,7 @@ dependencies: | |||
| collection: ^1.15.0 | |||
| crypto: ^3.0.0 | |||
| dart_style: ^2.0.0 | |||
| frontend_server_client: ^3.0.0 | |||
| frontend_server_client: ^4.0.0 | |||
There was a problem hiding this comment.
If we don't need any changes, then >=3.0.0 <5.0.0 should work just fine and avoid needing to also update package:test.
But, we would want to run through CI once with version 4.0.0 pinned just to make sure it does work:
dependency_overrides:
frontend_server_client: 4.0.0
There was a problem hiding this comment.
@a-siva is looking to delete the AppJIT snapshot of frontend_server, which requires all dependents of package:frontend_server_client to stop using versions < 4.0.0. I was going to make the breaking change request for deleting the AppJIT snapshot after updating packages' constraints on package:frontend_server_client, but now I think it makes sense to get approval for the breaking change first and use that approval to contextualize why constraints need to be updated. So, I'll make the breaking change request first.
There was a problem hiding this comment.
It actually still makes sense to keep the constraint at wide in this package. This is because:
- A
^4.0.0constraint won't actually help anybody get onto the latest version (the workflow is the same, there is no scenario where apub upgradewould give a newer version due to this constraint). If a user can't get version 4.x of frontend_server_client for some reason, it would just select an older version of this package, which allows the older frontend_server_client. - Increasing the constraint means users on older SDKs (where frontend_server_client version 3.x is valid) won't be able to get new versions of this package.
So, there is some downside but no actual upside.
There was a problem hiding this comment.
Put another way, version constraints on dependencies are useful only to express the versions of those dependencies that your package is API compatible with. They are not useful (do not work) for enforcing that your users get a certain bug fix.
There was a problem hiding this comment.
That makes sense. Thanks for clarifying. I've changed the constraints and have included the 4.0.0 dependency_override for now.
There was a problem hiding this comment.
I think we actually don't need to make a breaking change request to delete the AppJIT frontend_server snapshot. frontend_server_client 4.0.0 is the first version of the package to have an SDK constraint that accepts SDK versions >= 3.0.0. The frontend_server_client 3.3.0 verison that you referred to here (dart-lang/webdev#2263 (comment)) was never published.
derekxu16
force-pushed
the
update-frontend-server-client-constraint
branch
from
5962197 to
8da48d3
Compare
derekxu16
changed the title
Co-authored-by: Jacob MacDonald <jakemac@google.com>
|
@derekxu16 do we need a release of this soon? |
That would be ideal. Thanks! |
|
#3663 will do the release |
No description provided.