refactor build fn to use a class for managing state #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Essentially this just moves all top level functions to instance methods, and zone-local values to properties. I also simplified some argument signatures by adding additional properties. |
| final AssetWriter _writer; | ||
| final PackageGraph _packageGraph; | ||
| final List<List<Phase>> _phaseGroups; | ||
| Map<String, Set<AssetId>> _inputsByPackage; |
There was a problem hiding this comment.
nit: Make this final & assign right away.
Change the assignment in _initializeInputsByPackage to a call to clear()
|
LGTM |
jakemac53
force-pushed
the
refactor-build
branch
from
6608b4f to
27c1b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43