added top level watch function #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test is flaky on the bots right now, I will work on fixing that. |
| Stack Trace: | ||
| ${result.stackTrace}'''); | ||
| } | ||
| print(result); |
There was a problem hiding this comment.
Consider stdout for success & stderr for failures
|
|
||
| // Handle the first SIGINT, and shut down gracefully. Second one causes a | ||
| // full shutdown. | ||
| terminateEventStream ??= ProcessSignal.SIGINT.watch(); |
There was a problem hiding this comment.
Move terminateEventStream logic to a helper
|
Ok updated, still working on fixing the test though |
|
LGTM when LGT Travis |
kevmoo
added
type-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #6. For now this just does full rebuilds, not incremental ones.