Track inputs for GeneratedAssetNodes #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
commented
Nov 7, 2017
| }, writer: writer); | ||
| }); | ||
|
|
||
| test('invalidates generated assets based on graph age', () async { |
There was a problem hiding this comment.
note that I deleted this test, it wasn't applicable any more and should have been deleted during the migration to content hashes
natebosch
approved these changes
Nov 7, 2017
| var removedInputs = node.inputs.difference(reader.assetsRead); | ||
| node.inputs.removeAll(removedInputs); | ||
| for (var input in removedInputs) { | ||
| // TODO: special type of dependency here? This means the primary input |
There was a problem hiding this comment.
IMO it's fine to always treat the primary input like it was read. The edge cases shouldn't break anything, at worst builds are slightly less optimal
There was a problem hiding this comment.
ya, thats pretty much my same line of thinking for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the set of dependencies for a given generated asset could never be reduced except if those files were deleted.
It also partially unblocks #371.