Change cache location #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -168,7 +168,7 @@ class BuildImpl { | |||
|
|
|||
| /// Asset containing previous asset dependency graph. | |||
| AssetId get _assetGraphId => | |||
| new AssetId(_packageGraph.root.name, '.build/asset_graph.json'); | |||
| new AssetId(_packageGraph.root.name, '.dart_tool/build/asset_graph.json'); | |||
There was a problem hiding this comment.
DRY this up. Make a const in lib/src/some_util.dart or something.
https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming)
There was a problem hiding this comment.
But it only appears twice! I did do this though.
There was a problem hiding this comment.
...I'd say three times, if you count the help text 😄
|
one comment, otherwise LGTM |
jakemac53
force-pushed
the
change-cache-location
branch
from
52a2f5d to
7bdc9e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #68