Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect member conflict tests #179

Closed
askeksa-google opened this issue Oct 29, 2018 · 1 comment
Closed

Incorrect member conflict tests #179

askeksa-google opened this issue Oct 29, 2018 · 1 comment
Assignees
@ngolovleva

Comments

@askeksa-google
Copy link

Rules for member conflicts are described and discussed in dart-lang/sdk#33235. Some co19 tests expect compile-time errors for situations which are not defined to be conflicts. These are marked in https://github.com/dart-lang/sdk/blob/master/tests/co19_2/co19_2-kernel.status as Legal, see #33235.

There is a corresponding issue for fixing tests to conform to these rules: dart-lang/sdk#33238
@askeksa-google askeksa-google mentioned this issue Oct 29, 2018
Closed
ngolovleva added a commit that referenced this issue Nov 14, 2018
@ngolovleva
Fix for issue #179. Names conflict fixed
119bf06
sgrekhov pushed a commit that referenced this issue Nov 14, 2018
Merge pull request #190 from dart-lang/issue179
481920e 
Fix for issue #179. Names conflict fixed
@sgrekhov
Copy link
Contributor

Fixed by #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngolovleva ngolovleva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrekhov @ngolovleva @askeksa-google