Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer error changes with Constant_Constructors/not_a_constant_in_superclass_t02 #2232

Closed
kallentu opened this issue Aug 23, 2023 · 0 comments
Closed

Analyzer error changes with Constant_Constructors/not_a_constant_in_superclass_t02 #2232

kallentu opened this issue Aug 23, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@kallentu
Copy link
Member

After the changes in https://dart-review.googlesource.com/c/sdk/+/319911, there's new errors in these two files that need updating


/==================================================================================================================================================\
| co19/Language/Classes/Constructors/Constant_Constructors/not_a_constant_in_superclass_t02 broke (Pass -> MissingCompileTimeError, expected Pass) |
\==================================================================================================================================================/

--- Command "dart2analyzer" (took 69ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart out/ReleaseX64/gen/dartanalyzer.dart.snapshot -Dtest_runner.configuration=analyzer-asserts-linux --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json --format=json /b/s/w/ir/cache/builder/sdk/tests/co19/src/Language/Classes/Constructors/Constant_Constructors/not_a_constant_in_superclass_t02.dart

static error failures:
- Missing expected unspecified error at line 37, column 3, length 9.

--- Re-run this test:
python3 tools/test.py -n analyzer-asserts-linux co19/Language/Classes/Constructors/Constant_Constructors/not_a_constant_in_superclass_t02


/====================================================================================================================================================\
| co19_2/Language/Classes/Constructors/Constant_Constructors/not_a_constant_in_superclass_t02 broke (Pass -> MissingCompileTimeError, expected Pass) |
\====================================================================================================================================================/

--- Command "dart2analyzer" (took 92ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart out/ReleaseX64/gen/dartanalyzer.dart.snapshot -Dtest_runner.configuration=analyzer-asserts-linux --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json --format=json /b/s/w/ir/cache/builder/sdk/tests/co19_2/src/Language/Classes/Constructors/Constant_Constructors/not_a_constant_in_superclass_t02.dart

static error failures:
- Missing expected unspecified error at line 38, column 3, length 1.

--- Re-run this test:
python3 tools/test.py -n analyzer-asserts-linux co19_2/Language/Classes/Constructors/Constant_Constructors/not_a_constant_in_superclass_t02
@sgrekhov sgrekhov self-assigned this Aug 24, 2023
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Aug 24, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 24, 2023
@sgrekhov
dart-lang#2232. Fix secondary errors in not_a_constant_in_superclass_…
5467f3e 
…t02.dart
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 24, 2023
@sgrekhov
dart-lang#2232. Fix secondary errors in not_a_constant_in_superclass_…
5b6d9f1 
…t02.dart
eernstg pushed a commit that referenced this issue Aug 24, 2023
@sgrekhov
#2232. Fix secondary errors in not_a_constant_in_superclass_t02.dart (#…
0454b17 
…2234)
eernstg pushed a commit that referenced this issue Aug 24, 2023
@sgrekhov
#2232. Fix secondary errors in not_a_constant_in_superclass_t02.dart (#…
a1918f1 
…2233)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Aug 24, 2023
@sgrekhov
[co19] Roll co19_2 to 0454b178fdf6697e898b5e5c7ee553a9bc266faa
b6aa6db 
2023-08-24 sgrekhov22@gmail.com dart-lang/co19#2232. Fix secondary errors in not_a_constant_in_superclass_t02.dart (dart-lang/co19#2234)

Change-Id: I382acf4573314a19624eae308a2f3e39794dc7d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322403
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Aug 25, 2023
@sgrekhov @athomas
[co19] Roll co19 to 910330408dd6af6b8f58c5d26464dbe0ce76e476
7e218c4 
2023-08-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2236. Expect a secondary error for CFE in syntax_A08_t03.dart (dart-lang/co19#2237)
2023-08-24 sgrekhov22@gmail.com dart-lang/co19#2232. Fix secondary errors in not_a_constant_in_superclass_t02.dart (dart-lang/co19#2233)
2023-08-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2230. Fix roll failures (dart-lang/co19#2231)
2023-08-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2228. Fix syntax error in static_analysis_extension_types_A10_t08.dart (dart-lang/co19#2229)
2023-08-23 sgrekhov22@gmail.com dart-lang/co19#1400. Extension types subtyping tests. Resolve name conflict, add missing tests (dart-lang/co19#2227)
2023-08-23 sgrekhov22@gmail.com dart-lang/co19#1400. Add tests for external members, covariant parameters, nullable supertypes (dart-lang/co19#2225)
2023-08-23 sgrekhov22@gmail.com dart-lang/co19#2217. Add tests for calculating of the least upper bound for extension types (dart-lang/co19#2223)
2023-08-22 sgrekhov22@gmail.com Fixes dart-lang/co19#2224. Remove excessive error expectation for CFE (dart-lang/co19#2226)
2023-08-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2221. Replace inline classes by extension types (dart-lang/co19#2222)
2023-08-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2219. Replace `inline class` by `extension type` in test description (dart-lang/co19#2220)
2023-08-18 sgrekhov22@gmail.com dart-lang/co19#2142. Add Subtyping tests for extension types (dart-lang/co19#2215)
2023-08-18 sgrekhov22@gmail.com Fixes dart-lang/co19#2216. Add test for extension type abstract members (dart-lang/co19#2218)
2023-08-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2213. Fix stack trace comparison (dart-lang/co19#2214)

Change-Id: I009f43878130f934fc6c2eea3368f9763c94e7a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322660
Reviewed-by: Alexander Thomas <athom@google.com>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @kallentu