co19/LanguageFeatures/Parts-with-imports/grammar_A04_t01

[scheglov]

We don't report an error on the part directive because in principle the target file exists, and even says that it is a part.

FAILED: dart2analyzer-none release_arm64 co19/LanguageFeatures/Parts-with-imports/grammar_A04_t01
Expected: Pass
Actual: MissingCompileTimeError

--- Command "dart2analyzer" (took 33ms):
DART_CONFIGURATION=ReleaseARM64 sdk/bin/dart --packages=.dart_tool/package_config.json pkg/analyzer_cli/bin/analyzer.dart --use-analysis-driver-memory-byte-store --dart-sdk=/Users/scheglov/Source/Dart/sdk.git/sdk/sdk -Dtest_runner.configuration=custom-configuration-1 --enable-experiment=enhanced-parts --ignore-unrecognized-flags --packages=/Users/scheglov/Source/Dart/sdk.git/sdk/.dart_tool/package_config.json --format=json /Users/scheglov/Source/Dart/sdk.git/sdk/tests/co19/src/LanguageFeatures/Parts-with-imports/grammar_A04_t01.dart

static error failures:
- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Parts-with-imports/grammar_A04_t01_part1.dart line 31, column 5, length 4.

--- Re-run this test:
python3 tools/test.py -m release -c dart2analyzer -a arm64 co19/LanguageFeatures/Parts-with-imports/grammar_A04_t01

[scheglov]

I'm on the fence about co19/LanguageFeatures/Parts-with-imports/grammar_A03_t01 where we do part of a file that uses part of lib.name. We already report part of lib.name in the part, should we do this also on part? https://dart-review.googlesource.com/c/sdk/+/387820 will start reporting on the part directive.

[sgrekhov]

#2912 fixes grammar_A04_t01. For now, with https://dart-review.googlesource.com/c/sdk/+/387820 grammar_A03_t01 passes, so I didn't change it. Please file a separate issue for grammar_A03_t01 if needed.

[eernstg]

I don't know how the error messages about part of lib.name are otherwise positioned, but do note that https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Parts-with-imports/grammar_A04_t01_part1.dart has a syntax error as long as it contains two <partHeader> directives.

[sgrekhov]

Revert. #2913

[scheglov]

We (the analyzer team) decided that we don't want to report an error on part, only on part of dotted.name;.

So, it would be good to remove the expectation from co19/LanguageFeatures/Parts-with-imports/grammar_A03_t01.

FAILED: dart2analyzer-none release_arm64 co19/LanguageFeatures/Parts-with-imports/grammar_A03_t01
Expected: Pass
Actual: MissingCompileTimeError

--- Command "dart2analyzer" (took 112ms):
DART_CONFIGURATION=ReleaseARM64 sdk/bin/dart --packages=.dart_tool/package_config.json pkg/analyzer_cli/bin/analyzer.dart --use-analysis-driver-memory-byte-store --dart-sdk=/Users/scheglov/Source/Dart/sdk.git/sdk/sdk -Dtest_runner.configuration=custom-configuration-1 --enable-experiment=enhanced-parts --ignore-unrecognized-flags --packages=/Users/scheglov/Source/Dart/sdk.git/sdk/.dart_tool/package_config.json --format=json /Users/scheglov/Source/Dart/sdk.git/sdk/tests/co19/src/LanguageFeatures/Parts-with-imports/grammar_A03_t01.dart

static error failures:
- Missing expected unspecified error at tests/co19/src/LanguageFeatures/Parts-with-imports/grammar_A03_t01.dart line 31, column 7, length 26.

--- Re-run this test:
python3 tools/test.py -m release -c dart2analyzer -a arm64 co19/LanguageFeatures/Parts-with-imports/grammar_A03_t01