#2080. Move Correct member overrides to Superinterfaces folder
#2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Jun 22, 2023
Remove conflict with master
|
@sgrekhov, the PR is reported as having a conflict. I changed line 50 in Language/Interfaces/Superinterfaces/Correct_Member_Overrides/correct_member_overrides_A03_t06.dart, but that wasn't sufficient. Could you take a look? Presumably it's just another library which has been updated in master after the commit where this branch started. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 26, 2023
2023-06-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2080. Fix typo in correct_member_overrides_A03_t14.dart (dart-lang/co19#2097) 2023-06-22 sgrekhov22@gmail.com dart-lang/co19#2080. Move `Correct member overrides` to Superinterfaces folder (dart-lang/co19#2096) 2023-06-22 sgrekhov22@gmail.com Fixes dart-lang/co19#2083. Expect `unspecified` error in const_collections_A08_t01.dart (dart-lang/co19#2084) 2023-06-22 sgrekhov22@gmail.com dart-lang/co19#2080. Update assertion texts, add mixin syntax test (dart-lang/co19#2095) 2023-06-22 sgrekhov22@gmail.com dart-lang/co19#2080. Add correct member overrides tests. Part 2. Setters (dart-lang/co19#2093) 2023-06-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2090. Add required final instance variable to a inline class (dart-lang/co19#2091) 2023-06-20 sgrekhov22@gmail.com dart-lang/co19#2080. Add correct member overrides tests. Part 1. (dart-lang/co19#2088) 2023-06-20 sgrekhov22@gmail.com dart-lang/co19#2080. Update assertion texts of overriding tests (dart-lang/co19#2089) 2023-06-15 sgrekhov22@gmail.com dart-lang/co19#1400. Add inline classes members override test (dart-lang/co19#2085) Change-Id: I4a5a112cb11590b0c15032a65f5b80193a42b27b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311160 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11.2.2. Correct member overridesis part of11.2. Superinterfaceschapter. Move tests to follow the specification structure