Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2388. Add tests for the new method/setter rules. Update assertions #2393

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Fixes #2388. Add tests for the new method/setter rules. Update assertions #2393

merged 3 commits into from
Nov 23, 2023

Conversation

sgrekhov
Copy link
Contributor

No description provided.

eernstg
eernstg reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However, there are some typos, and the @assertion talks about a different thing than the thing which is actually tested in a couple of cases.

LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t01.dart Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t02.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t06.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t06.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t06.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t07.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t07.dart Outdated Show resolved Hide resolved
@sgrekhov
Copy link
Contributor Author

Tests updated. Changes

  • tests for extension-type members and non-extension type members are separated
  • removed tests that check redeclaration instead of precluding
  • static_analysis_member_invocation_A06_t*.dart will re reordered after the merge in a separate PR

@sgrekhov sgrekhov requested a review from eernstg November 23, 2023 09:21
eernstg
eernstg reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think a couple of declarations are unused. Also, some future reader is probably going to be happy if class names and extension type names follow the conventions (so V... typically means "a helper declaration whose kind is extension type", not "a class").

LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t03.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t08.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A08_t04.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A08_t05.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A08_t02.dart Outdated Show resolved Hide resolved
sgrekhov
sgrekhov commented Nov 23, 2023
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Unused code removed, classes renamed

LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t03.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A08_t02.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A08_t04.dart Outdated Show resolved Hide resolved
@sgrekhov sgrekhov requested a review from eernstg November 23, 2023 10:32
eernstg
eernstg approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eernstg eernstg merged commit c3c55b0 into dart-lang:master Nov 23, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 24, 2023
@sgrekhov @athomas
[co19] Roll co19 to 85c868a325bc92f4e743958077ad0ad2eb58c81f
2534859 
2023-11-23 athom@google.com Merge pull request dart-lang/co19#2395 from dart-lang/merge-pre-nnbd
2023-11-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2390. Fix tests according to the new method/setter rules (dart-lang/co19#2392)
2023-11-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2388. Add tests for the new method/setter rules. Update assertions (dart-lang/co19#2393)
2023-11-23 athom@google.com Merge remote-tracking branch 'origin/pre-nnbd' into master
2023-11-22 sgrekhov22@gmail.com Fixes dart-lang/co19#2389. Add additional error expectation for analyzer (dart-lang/co19#2391)
2023-11-21 sgrekhov22@gmail.com dart-lang/co19#2342. Update nullability tests according to the new rules (dart-lang/co19#2385)
2023-11-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2384. Fix not well-bound extension types. Add function-type dynamic test (dart-lang/co19#2387)

Change-Id: Ic3848f6f39fd42b01bfed5feac3d922c6f5a53d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338120
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
@sgrekhov sgrekhov deleted the co19-2388 branch January 21, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg