-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2559. Add tests checking that augment
is a built-in identifier
#2560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just mentioned a couple of extra cases that we might as well cover.
// ^^^^^^^ | ||
// [analyzer] unspecified | ||
// [cfe] unspecified | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also have a type variable declared by a type alias or by a function type:
typedef int F1<augment>();
typedef F2<augment extends Comparable<augment>> = int Function();
const void Function<augment>()? c = null;
Added these test cases to the other buil-in identifiers tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2024-03-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests checking that `augment` is a built-in identifier (dart-lang/co19#2560) 2024-03-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.0.0 to 4.1.0 (dart-lang/co19#2557) 2024-02-23 sgrekhov22@gmail.com dart-lang/co19#2548. Add tests for out parameter in a contrvariant position (dart-lang/co19#2555) 2024-02-22 sgrekhov22@gmail.com dart-lang/co19#2548. Add variance modifier declaration tests (dart-lang/co19#2554) 2024-02-21 sgrekhov22@gmail.com dart-lang/co19#2548. Add `out` and `inout` to built-in identifiers tests (dart-lang/co19#2553) Change-Id: Idd8ddf54f4cd7bb04b7296068653bee336d6d193 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356460 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
According to the Augmentation libraries specification