Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2943. Use name dartaotruntime instead of dart_precompiled_runtime #2973

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg
Copy link
Member

eernstg commented Nov 11, 2024

@a-siva, do you have further comments?

@eernstg
Copy link
Member

eernstg commented Nov 11, 2024

@a-siva, I'll land this, please give us a heads-up if you're worried about anything.

@eernstg eernstg merged commit 5a073e6 into dart-lang:master Nov 11, 2024
2 checks passed
@a-siva
Copy link

a-siva commented Nov 11, 2024

No further comments. Thanks for taking care of it.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 15, 2024
2024-11-14 sgrekhov22@gmail.com dart-lang/co19#2956. Add more tests for the type `void` (dart-lang/co19#2977)
2024-11-12 sgrekhov22@gmail.com dart-lang/co19#2956. Rename, move and update existing return from `void` tests (dart-lang/co19#2975)
2024-11-12 sgrekhov22@gmail.com dart-lang/co19#2956. Add more type void tests. Update existing ones (dart-lang/co19#2974)
2024-11-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2943. Use name `dartaotruntime` instead of `dart_precompiled_runtime` (dart-lang/co19#2973)
2024-11-11 sgrekhov22@gmail.com dart-lang/co19#2953. Add inference with bounds tests (dart-lang/co19#2957)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I1f3c534a1e69af28c9adb93bdc13b8741a64e7f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395500
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants