-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2559. Add more augmented expression tests for class-like declarations #3019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A couple of words in the description do not seem to match the actual test.
/// identifier `augmented` occurs in Dm. | ||
/// | ||
/// @description Checks that it is a compile-time error if an augmenting class | ||
/// declaration extends a type named `augmented`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps:
/// declaration extends a type named `augmented`. | |
/// declaration extends a type that contains the name `augmented`. |
Similarly for a few more tests below.
Updated. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2024-12-19 sgrekhov22@gmail.com dart-lang/co19#2976. Add equality tests. Part 1. (dart-lang/co19#3021) 2024-12-19 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests for class-like declarations (dart-lang/co19#3019) 2024-12-18 sgrekhov22@gmail.com Fix Finalizer_A01_t04.dart test (dart-lang/co19#3020) 2024-12-18 sgrekhov22@gmail.com dart-lang/co19#2559. Fix metadata tests (dart-lang/co19#3018) 2024-12-17 sgrekhov22@gmail.com dart-lang/co19#2559. Add metadata tests. Part 1. (dart-lang/co19#3017) 2024-12-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmented expression tests (dart-lang/co19#3016) 2024-12-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for reserved word `augmented` in constructors. Part 2. (dart-lang/co19#3015) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Idf2d4813fdca6d4107ee17d508cf5f8b27b1b4ff Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401882 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
No description provided.