-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3054. Add generic method instantiation tests #3062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of comments!
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A01_t01.dart
Outdated
Show resolved
Hide resolved
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A01_t02.dart
Outdated
Show resolved
Hide resolved
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A01_t02.dart
Outdated
Show resolved
Hide resolved
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A03_t01.dart
Outdated
Show resolved
Hide resolved
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A03_t02.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. PTAL.
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A01_t01.dart
Outdated
Show resolved
Hide resolved
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A01_t02.dart
Outdated
Show resolved
Hide resolved
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A01_t02.dart
Outdated
Show resolved
Hide resolved
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A03_t02.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I did have an extra comment on the throwing test that we briefly talked about this morning.
...age/Expressions/Property_Extraction/Generic_Method_Instantiation/generic_method_A01_t02.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2025-02-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for enum with empty list of values (dart-lang/co19#3066) 2025-02-04 sgrekhov22@gmail.com dart-lang/co19#3054. Add more method clozurization tests (dart-lang/co19#3060) 2025-02-04 sgrekhov22@gmail.com Fixes dart-lang/co19#3063. Add additional "correct member overrides" test (dart-lang/co19#3065) 2025-02-04 sgrekhov22@gmail.com dart-lang/co19#3054. Add more test cases to closurization tests. Part 1. (dart-lang/co19#3061) 2025-02-04 sgrekhov22@gmail.com dart-lang/co19#3054. Add generic method instantiation tests (dart-lang/co19#3062) 2025-02-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.6.0 to 4.7.0 in the github-actions group (dart-lang/co19#3064) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I5d1b9a2d7231b2b8f20e97e3f9da940f4632957f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408260 Reviewed-by: Alexander Thomas <athom@google.com> Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
No description provided.