#3315. Add tests for formal parameters. Part 5. #3348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Oct 13, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good! Just two nit-picking comments.
| } | ||
|
|
||
| class C2<T> { | ||
| this({var String v1 = "", final T? v2, var bool v3 = true}); |
Member
There was a problem hiding this comment.
Perhaps use final/var/final in this second test, just like in the previous library.
| } | ||
|
|
||
| class C2<T> { | ||
| this({required var int v1, required final T v2, required var bool v3}); |
Member
There was a problem hiding this comment.
Same issue here, using final/var/final rather than var/final/var in the second test seems to give slightly better coverage, so we might as well do that.
Contributor
Author
|
Updated. PTAL. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 17, 2025
2025-10-16 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for super parameters (dart-lang/co19#3352) 2025-10-16 sgrekhov22@gmail.com dart-lang/co19#3315. Add more declaring constructors tests (dart-lang/co19#3351) 2025-10-15 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for initializer list (dart-lang/co19#3349) 2025-10-15 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for the `new` keyword (dart-lang/co19#3350) 2025-10-14 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for formal parameters. Part 5. (dart-lang/co19#3348) 2025-10-13 sgrekhov22@gmail.com dart-lang/co19#3315. Update assertions. Add test for setters. (dart-lang/co19#3347) 2025-10-10 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for formal parameters. Part 4. (dart-lang/co19#3346) 2025-10-10 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for formal parameters. Part 3. (dart-lang/co19#3345) 2025-10-10 sgrekhov22@gmail.com dart-lang/co19#3315. Add tests for formal parameters. Part 2. (dart-lang/co19#3344) R=athom@google.com, eernst@google.com Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: Ie4824457e4c1843e8406dbb7ba8c0a6a10728410 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455600 Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.