Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the implements clause of IntX #866

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Adjust the implements clause of IntX #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
153efae
Introduces changes as in https://dart-review.googlesource.com/c/core/…
eernstg Feb 27, 2025
fcb0c1c
Update pkgs/fixnum/CHANGELOG.md
eernstg Feb 28, 2025
d2060be
Update pkgs/fixnum/pubspec.yaml
eernstg Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkgs/fixnum/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 1.2.0-wip

* Change `IntX` such that it implements `Comparable<IntX>`. This makes it
possible for `IntX` (and in turn `Int64` and `Int32`) be used with methods
like `sortedBy` in the platform libraries.

## 1.1.1

* Require Dart `^3.1.0`
Expand Down
2 changes: 1 addition & 1 deletion pkgs/fixnum/lib/src/intx.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import 'int32.dart';
import 'int64.dart';

/// A fixed-precision integer.
abstract class IntX implements Comparable<Object> {
abstract class IntX implements Comparable<IntX> {
/// Addition operator.
IntX operator +(Object other);

Expand Down
2 changes: 1 addition & 1 deletion pkgs/fixnum/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: fixnum
version: 1.1.1
version: 1.2.0-wip
description: >-
Library for 32- and 64-bit signed fixed-width integers with consistent
behavior between native and JS runtimes.
Expand Down
Loading