Handle imports with "as" and "if" clauses in either order. #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #1550 fixed the bug where if you had both clauses, it would output them in the *wrong* order. But it turns out that the parser today allows them in *either* order even though the language spec doesn't. Since I've seen a handful of cases like this in the wild, instead of just failing to format, simply preserve the clause order that the user wrote.
Does it fail to format, or does it change the order to the correct one in the formatted code? |
|
Prior to this PR, it would change the order to the correct one in the formatter output. But that would then cause the formatter's own internal "I only make whitespace changes" sanity check to fail since it would see that as a non-whitespace change, which would then cause the formatter to abort writing that file. With this PR, it just keeps the order that the user wrote, which also then means it is only making whitespace changes. |
|
Oh I see from the other thread it trips the detection that something other than whitespace changed... |
natebosch
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1550 fixed the bug where if you had both clauses, it would output them in the wrong order. But it turns out that the parser today allows them in either order even though the language spec doesn't.
Since I've seen a handful of cases like this in the wild, instead of just failing to format, simply preserve the clause order that the user wrote.