Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash on an index cascade section followed by a method chain. #1556

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Don't crash on an index cascade section followed by a method chain. #1556

merged 2 commits into from
Sep 5, 2024

Conversation

munificent
Copy link
Member

I found this weird corner case in the wild when formatting a large corpus.

@munificent
Don't crash on an index cascade section followed by a method chain.
9e8e440 
I found this weird corner case in the wild when formatting a large
corpus.
natebosch
natebosch approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider expanding the commit message with an explanation of why that code snippet results in an IndexExpression with a null target.

@munificent
Copy link
Member Author

Good idea, done.

@munificent munificent merged commit 003cb15 into main Sep 5, 2024
7 checks passed
@munificent munificent deleted the index-cascade-chain branch September 5, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

@kallentu kallentu Awaiting requested review from kallentu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@munificent @natebosch