Write out extension type constructor docs (#3602)

dart-lang · Dec 12, 2023 · c4f304f · c4f304f
1 parent 7ac2a1c
commit c4f304f
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 13 deletions.
diff --git a/lib/src/generator/generator_frontend.dart b/lib/src/generator/generator_frontend.dart
@@ -194,6 +194,15 @@ class GeneratorFrontEnd implements Generator {
           _generatorBackend.generateExtensionType(
               packageGraph, lib, extensionType);
 
+          for (var constructor
+              in filterNonDocumented(extensionType.constructors)) {
+            if (!constructor.isCanonical) continue;
+
+            indexAccumulator.add(constructor);
+            _generatorBackend.generateConstructor(
+                packageGraph, lib, extensionType, constructor);
+          }
+
           for (var constant
               in filterNonDocumented(extensionType.constantFields)) {
             indexAccumulator.add(constant);

diff --git a/test/templates/extension_type_test.dart b/test/templates/extension_type_test.dart
@@ -89,7 +89,7 @@ class FooSub extends Foo<int> {}
 
 extension type One<E>(Foo<E> it) {
   /// A named constructor.
-  MyIterable.named(Foo<E> e);
+  One.named(Foo<E> e);
 
   /// An instance method.
   void m1() {}
@@ -147,6 +147,28 @@ dartdoc:
       ]);
     });
 
+    test('primary constructor page is rendered', () async {
+      var constructorPageLines = resourceProvider
+          .readLines([packagePath, 'doc', 'lib', 'One', 'One.html']);
+      constructorPageLines.expectMainContentContainsAllInOrder([
+        matches(
+          '<span class="kind-constructor">One&lt;<wbr>'
+          '<span class="type-parameter">E</span>&gt;</span> constructor',
+        )
+      ]);
+    });
+
+    test('named constructor page is rendered', () async {
+      var constructorPageLines = resourceProvider
+          .readLines([packagePath, 'doc', 'lib', 'One', 'One.named.html']);
+      constructorPageLines.expectMainContentContainsAllInOrder([
+        matches(
+          '<span class="kind-constructor">One&lt;<wbr>'
+          '<span class="type-parameter">E</span>&gt;.named</span> constructor',
+        )
+      ]);
+    });
+
     test('page contains representation type', () async {
       oneLines.expectMainContentContainsAllInOrder([
         matches('<dt>on</dt>'),
@@ -209,18 +231,13 @@ dartdoc:
       ]);
     });
 
-    test(
-      'page contains (static) constants',
-      // TODO(srawlins): Implement.
-      skip: true,
-      () async {
-        oneLines.expectMainContentContainsAllInOrder([
-          matches('<h2>Constants</h2>'),
-          matches('<a href="../lib/One/c1-constant.html">c1</a>'),
-          matches('A constant.'),
-        ]);
-      },
-    );
+    test('page contains (static) constants', () async {
+      oneLines.expectMainContentContainsAllInOrder([
+        matches('<h2>Constants</h2>'),
+        matches('<a href="../lib/One/c1-constant.html">c1</a>'),
+        matches('A constant.'),
+      ]);
+    });
 
     test('page contains representation field', () async {
       oneLines.expectMainContentContainsAllInOrder([