Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke tests for function as type parameter and triple-shift #2603

Merged
merged 28 commits into from
Apr 2, 2021

Conversation

jcollins-g
Copy link
Contributor

Fixes #2518 and adds some basic testing for #2517.

No implementation required for triple-shift. Here are some sample screenshots of correct renders for it:

Screen Shot 2021-04-02 at 10 00 33 AM
Screen Shot 2021-04-02 at 10 01 01 AM
Screen Shot 2021-04-02 at 10 01 24 AM

One of the places types are not appearing correctly for functions as type arguments includes constructors, here:

Screen Shot 2021-04-02 at 10 02 22 AM

So that part is not finished yet.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Apr 2, 2021
@jcollins-g jcollins-g requested a review from devoncarew April 2, 2021 18:53
@jcollins-g jcollins-g merged commit 31ec93e into dart-lang:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow >>> as an overridable operator.
3 participants