Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markdown templates and their generation. #3600

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Conversation

kallentu
Copy link
Member

@kallentu kallentu commented Dec 12, 2023

  • Removed lib/templates/md/
  • Removed logic for generating aot_renderers_for_markdown.dart and similar files.
  • Removed the generated files themselves.

#3535


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kallentu kallentu requested a review from srawlins December 12, 2023 19:21
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 4k lines! Looks great.

@kallentu kallentu merged commit 72c0f2c into main Dec 13, 2023
10 of 11 checks passed
@kallentu kallentu deleted the remove-aot-md branch December 13, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants