-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include extension members on the extended type's page #3863
Merged
srawlins
merged 2 commits into
dart-lang:main
from
srawlins:include-extension-methods-2
Sep 10, 2024
Merged
Include extension members on the extended type's page #3863
srawlins
merged 2 commits into
dart-lang:main
from
srawlins:include-extension-methods-2
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dart-lang#2021 In this feature, we list extension members of an extended type on that extended type's page. The members are listed inline with other instance members and are cross-linked over to the extension's member pages. * Introduce `availableInstanceMethods` as a list combining both instance methods declared in a container, and instance methods declared in an applicable extension. The same for `availableInstanceOperators` and `availableInstanceFields`. * Introduce some constructors like `Field.providedByExtension` for members that are provided by an extension. * Add lots of documentation clarifying _where_ various members come from. * We introduce a new getter on ElementType, `nameWithGenericsPlain`, which is not HTML-formatted, for use in HTML "title text."
e25a471
to
81d5f3e
Compare
Be excited, @dart-lang/analyzer-team, this is ready for review 😁 😀 😁 😀 |
bwilkerson
approved these changes
Sep 9, 2024
1b8bd22
to
79cbe22
Compare
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 23, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/8100ccf..526dbd5): 526dbd55 2024-09-15 Sam Rawlins Strip the enclosing package's lower-case name from a library's dir name (dart-lang/dartdoc#3883) 98dd9dad 2024-09-13 Sam Rawlins Add output-size info to the '--stats' flag on various tasks. (dart-lang/dartdoc#3879) 090b05ba 2024-09-13 Sam Rawlins Bump to 8.2.0 (dart-lang/dartdoc#3880) 0a529762 2024-09-12 Sam Rawlins Fix search which is not using canonical libraries as enclosing elements (dart-lang/dartdoc#3877) d4dff9a4 2024-09-12 Konstantin Scheglov Stop using 'augmented' from the element model. (dart-lang/dartdoc#3878) d6b865f9 2024-09-11 Sam Rawlins Support multiple partial calls from a single template (dart-lang/dartdoc#3873) 25c9edf3 2024-09-10 Parker Lougheed Standardize to newer SDK APIs (dart-lang/dartdoc#3872) b61de2f2 2024-09-10 Sam Rawlins Clean up some sorting, naming, and doc nits (dart-lang/dartdoc#3876) 55ce1164 2024-09-10 Sam Rawlins Use latest language version for DartFormatter (dart-lang/dartdoc#3875) 2a262818 2024-09-10 Sam Rawlins Comply with analyzer 6.9.0 APIs (dart-lang/dartdoc#3874) ca98b898 2024-09-09 Sam Rawlins Include extension members on the extended type's page (dart-lang/dartdoc#3863) mockito (https://github.com/dart-lang/mockito/compare/d0fda0c..b66be81): b66be81 2024-09-13 Googler Migration for analyzer APIs. stack_trace (https://github.com/dart-lang/stack_trace/compare/090d3d1..5b82965): 5b82965 2024-09-19 Ömer Sinan Ağacan Relax URI matching in V8 Wasm frame regex (dart-archive/stack_trace#161) 9b1ed4f 2024-09-19 Ömer Sinan Ağacan Add support for parsing Wasm stack frames of Chrome (V8), Firefox, Safari (dart-archive/stack_trace#159) d38eee8 2024-09-17 Ömer Sinan Ağacan Fix analysis issues (dart-archive/stack_trace#160) test (https://github.com/dart-lang/test/compare/9a2d155..22835e2): 22835e2e 2024-09-13 Nate Bosch Add support for multiple full paths on macos (dart-lang/test#2276) web (https://github.com/dart-lang/web/compare/933a37d..d8549a3): d8549a3 2024-09-13 Srujan Gaddam Add a generate-all flag to emit all bindings (dart-lang/web#302) Change-Id: Ib07e4c0eda9c8ea180ef989c7d9cf20c390457e8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386260 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
FMorschel
pushed a commit
to FMorschel/sdk
that referenced
this pull request
Sep 25, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/8100ccf..526dbd5): 526dbd55 2024-09-15 Sam Rawlins Strip the enclosing package's lower-case name from a library's dir name (dart-lang/dartdoc#3883) 98dd9dad 2024-09-13 Sam Rawlins Add output-size info to the '--stats' flag on various tasks. (dart-lang/dartdoc#3879) 090b05ba 2024-09-13 Sam Rawlins Bump to 8.2.0 (dart-lang/dartdoc#3880) 0a529762 2024-09-12 Sam Rawlins Fix search which is not using canonical libraries as enclosing elements (dart-lang/dartdoc#3877) d4dff9a4 2024-09-12 Konstantin Scheglov Stop using 'augmented' from the element model. (dart-lang/dartdoc#3878) d6b865f9 2024-09-11 Sam Rawlins Support multiple partial calls from a single template (dart-lang/dartdoc#3873) 25c9edf3 2024-09-10 Parker Lougheed Standardize to newer SDK APIs (dart-lang/dartdoc#3872) b61de2f2 2024-09-10 Sam Rawlins Clean up some sorting, naming, and doc nits (dart-lang/dartdoc#3876) 55ce1164 2024-09-10 Sam Rawlins Use latest language version for DartFormatter (dart-lang/dartdoc#3875) 2a262818 2024-09-10 Sam Rawlins Comply with analyzer 6.9.0 APIs (dart-lang/dartdoc#3874) ca98b898 2024-09-09 Sam Rawlins Include extension members on the extended type's page (dart-lang/dartdoc#3863) mockito (https://github.com/dart-lang/mockito/compare/d0fda0c..b66be81): b66be81 2024-09-13 Googler Migration for analyzer APIs. stack_trace (https://github.com/dart-lang/stack_trace/compare/090d3d1..5b82965): 5b82965 2024-09-19 Ömer Sinan Ağacan Relax URI matching in V8 Wasm frame regex (dart-archive/stack_trace#161) 9b1ed4f 2024-09-19 Ömer Sinan Ağacan Add support for parsing Wasm stack frames of Chrome (V8), Firefox, Safari (dart-archive/stack_trace#159) d38eee8 2024-09-17 Ömer Sinan Ağacan Fix analysis issues (dart-archive/stack_trace#160) test (https://github.com/dart-lang/test/compare/9a2d155..22835e2): 22835e2e 2024-09-13 Nate Bosch Add support for multiple full paths on macos (dart-lang/test#2276) web (https://github.com/dart-lang/web/compare/933a37d..d8549a3): d8549a3 2024-09-13 Srujan Gaddam Add a generate-all flag to emit all bindings (dart-lang/web#302) Change-Id: Ib07e4c0eda9c8ea180ef989c7d9cf20c390457e8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386260 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this feature, we list extension members of an extended type on that extended type's page. The members are listed inline with other instance members and are cross-linked over to the extension's member pages.
availableInstanceMethods
as a list combining both instance methods declared in a container, and instance methods declared in an applicable extension. The same foravailableInstanceOperators
andavailableInstanceFields
.Field.providedByExtension
for members that are provided by an extension.nameWithGenericsPlain
, which is not HTML-formatted, for use in HTML "title text."Here are some screenshots:
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.