New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore static issue with overridden field #3926

Merged

srawlins merged 1 commit into dart-lang:main from srawlins:overridden-field

Nov 11, 2024

Member

srawlins commented Nov 11, 2024

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Ignore static issue with overridden field

bd48020

Member Author

srawlins commented Nov 11, 2024

Ready for review @dart-lang/analyzer-team

pq approved these changes

View reviewed changes

srawlins merged commit 8003230 into dart-lang:main

7 checks passed

srawlins deleted the overridden-field branch

November 11, 2024 22:58

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [deps] rev dartdoc, http, shelf, tools

ca9c123

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/24c2a96..6bbd3d7):
  6bbd3d7b  2024-11-14  Sam Rawlins  Do not use SpecialClass to evaluate Enum or Interceptor (dart-lang/dartdoc#3928)
  dcc239a4  2024-11-12  Sam Rawlins  Refactor special case for how canonical enclosing containers are calculated (dart-lang/dartdoc#3925)
  80032309  2024-11-11  Sam Rawlins  Ignore static issue with overridden field (dart-lang/dartdoc#3926)

http (https://github.com/dart-lang/http/compare/03ced4d..2f954e1):
  2f954e1  2024-11-11  Brian Quinlan  Add macOS tests for `package:cupertino_http` (dart-lang/http#1403)

shelf (https://github.com/dart-lang/shelf/compare/1a141c7..0bb44cb):
  0bb44cb  2024-11-12  Devon Carew  add direct links to the package issues (dart-lang/shelf#455)

tools (https://github.com/dart-lang/tools/compare/66afa68..a6603a4):
  a6603a45  2024-11-11  Liam Appelbe  [coverage] Fix isolate resumption after service disposal (dart-lang/tools#1189)

Change-Id: I715f943ff69ae24b5126a7ddf883d31aed180632
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395402
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet