Fix lints and tests. #4070
Merged
Fix lints and tests. #4070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sigurdm |
sigurdm
reviewed
Jul 1, 2025
test/end2end/dartdoc_test.dart
Outdated
| @@ -110,7 +110,7 @@ void main() { | |||
| expect( | |||
| useSomethingInAnotherPackage.modelType.linkedName, | |||
| matches( | |||
| r'<a class="deprecated" href="https://pub.dev/documentation/meta/[^"]*/meta/Required-class.html">Required</a>')); | |||
| r'<a href="https://pub.dev/documentation/meta/[^"]*/meta/Required-class.html">Required</a>\?')); | |||
There was a problem hiding this comment.
Is this test change a consequence of the change above, or is it an already failing test thats fixed?
There was a problem hiding this comment.
updated the regexp PTAL, apparently different test versions output different text.
sigurdm
reviewed
Jul 1, 2025
sigurdm
approved these changes
Jul 1, 2025
|
Note: the CI test failure was tracked back to |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 2, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/38734ff..64dfa7f): 64dfa7f 2025-07-01 Jacob MacDonald move static argParser variable to a createArgParser function (dart-lang/ai#212) a5aa053 2025-07-01 dependabot[bot] Bump actions/cache from 4.2.2 to 4.2.3 in the github-actions group (dart-lang/ai#211) dartdoc (https://github.com/dart-lang/dartdoc/compare/f1fe177..882aea9): 882aea93 2025-07-01 dependabot[bot] Bump github/codeql-action from 3.28.18 to 3.29.2 in the github-actions group (dart-lang/dartdoc#4071) 3e3999a6 2025-07-01 István Soós Fix lints and tests. (dart-lang/dartdoc#4070) i18n (https://github.com/dart-lang/i18n/compare/9e2d047..ab90327): ab903279 2025-07-01 dependabot[bot] Bump softprops/action-gh-release in the github-actions group (dart-lang/i18n#984) test (https://github.com/dart-lang/test/compare/0793a2b..2be5ca0): 2be5ca06 2025-07-01 Devon Carew prep to publish package:checks 0.3.1 (dart-lang/test#2513) 3d5aaa3f 2025-07-01 dependabot[bot] Bump github/codeql-action from 3.28.18 to 3.29.2 in the github-actions group (dart-lang/test#2514) 8e703e28 2025-06-30 Seth Ladd Update README.md to clarify this is an experiment (dart-lang/test#2512) webdriver (https://github.com/google/webdriver.dart/compare/b8f511d..cfab787): cfab787 2025-07-01 dependabot[bot] Bump nanasess/setup-chromedriver (google/webdriver.dart#330) Change-Id: I28133768054260c588fba4a0cac3a60bd55d0fb2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438360 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.