add additional lints to dart_flutter_team_lints (#167)

* add additional lints to dart_flutter_team_lints

* mono_reo generate

* dart fix

* dartfmt

* revert unintentional changes

* updates from review

pkgs/blast_repo/lib/src/top_level.dart

@@ -6,13 +6,13 @@ import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
-import 'package:blast_repo/src/tweaks/mono_repo_tweak.dart';
 import 'package:git/git.dart';
 
 import 'repo_tweak.dart';
 import 'tweaks/auto_publish_tweak.dart';
 import 'tweaks/dependabot_tweak.dart';
 import 'tweaks/github_action_tweak.dart';
+import 'tweaks/mono_repo_tweak.dart';
 import 'tweaks/no_reponse_tweak.dart';
 import 'utils.dart';
 

pkgs/corpus/bin/deps.dart

@@ -57,7 +57,7 @@ void main(List<String> args) async {
 
   var targetPackage = await pub.getPackageInfo(packageName);
 
-  final dateOneYearAgo = DateTime.now().subtract(Duration(days: 365));
+  final dateOneYearAgo = DateTime.now().subtract(const Duration(days: 365));
 
   var limit = packageLimit == null ? null : int.parse(packageLimit);
 

pkgs/corpus/lib/api.dart

@@ -49,7 +49,7 @@ class ApiUsage {
       'packages': fromPackages.toJson(),
       'libraries': fromLibraries.toJson(),
     };
-    file.writeAsStringSync(JsonEncoder.withIndent('  ').convert(json));
+    file.writeAsStringSync(const JsonEncoder.withIndent('  ').convert(json));
   }
 
   /// Returns whether we found any references to the target package.
@@ -70,8 +70,8 @@ class ApiUsage {
   }
 
   static ApiUsage fromFile(PackageInfo packageInfo, File file) {
-    var json =
-        JsonDecoder().convert(file.readAsStringSync()) as Map<String, dynamic>;
+    var json = const JsonDecoder().convert(file.readAsStringSync())
+        as Map<String, dynamic>;
     return ApiUsage(
       packageInfo,
       References.fromJson(json['packages'] as Map<String, dynamic>),

pkgs/corpus/lib/report.dart

@@ -4,9 +4,8 @@
 
 import 'dart:io';
 
-import 'package:corpus/pub.dart';
-
 import 'api.dart';
+import 'pub.dart';
 import 'utils.dart';
 
 abstract class ReportTarget {

pkgs/corpus/test/api_test.dart

@@ -18,10 +18,10 @@ void main() {
 
     setUp(() {
       var json =
-          JsonDecoder().convert(_sampleUsageJson) as Map<String, dynamic>;
+          const JsonDecoder().convert(_sampleUsageJson) as Map<String, dynamic>;
       sampleUsage = ApiUsage(
-        PackageInfo.from(
-            JsonDecoder().convert(_packageInfoJson) as Map<String, dynamic>),
+        PackageInfo.from(const JsonDecoder().convert(_packageInfoJson)
+            as Map<String, dynamic>),
         References.fromJson(json['packages'] as Map<String, dynamic>),
         References.fromJson(json['libraries'] as Map<String, dynamic>),
       );
@@ -42,8 +42,8 @@ void main() {
       sampleUsage.toFile(tempFile);
 
       var result = ApiUsage.fromFile(
-        PackageInfo.from(
-            JsonDecoder().convert(_packageInfoJson) as Map<String, dynamic>),
+        PackageInfo.from(const JsonDecoder().convert(_packageInfoJson)
+            as Map<String, dynamic>),
         tempFile,
       );
 

pkgs/corpus/test/data/dart_library_references.dart

@@ -11,6 +11,6 @@ void main() {
   map['three'] = 3;
   print(map);
 
-  var local = Queue();
-  Queue.castFrom(local);
+  var local = Queue<Object>();
+  Queue.castFrom<Object, String>(local);
 }

pkgs/dart_flutter_team_lints/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 2.0.0
+
+- Enable `strict-inference`.
+- Added `comment_references`.
+- Added `conditional_uri_does_not_exist`.
+- Added `prefer_const_constructors`.
+- Added `prefer_relative_imports`.
+- Added `test_types_in_equals`.
+- Added `use_super_parameters`.
+
 ## 1.0.0
 
 - Added `collection_methods_unrelated_type`.

pkgs/dart_flutter_team_lints/lib/analysis_options.yaml

@@ -18,6 +18,7 @@ include: package:lints/recommended.yaml
 analyzer:
   language:
     strict-casts: true
+    strict-inference: true
 
 linter:
   rules:
@@ -35,8 +36,10 @@ linter:
     - lines_longer_than_80_chars
     - omit_local_variable_types
     - prefer_asserts_in_initializer_lists
+    - prefer_const_constructors
     - prefer_generic_function_type_aliases
     - prefer_is_empty
+    - prefer_relative_imports
     - prefer_single_quotes
     - prefer_typing_uninitialized_variables
     - sort_pub_dependencies
@@ -47,18 +50,22 @@ linter:
     - unnecessary_statements
     - use_is_even_rather_than_modulo
     - use_string_in_part_of_directives
+    - use_super_parameters
 
     # correctness
     - always_declare_return_types
     - avoid_catching_errors
     - avoid_dynamic_calls
     - await_only_futures
     - collection_methods_unrelated_type
+    - comment_references
+    - conditional_uri_does_not_exist
     - dangling_library_doc_comments
     - hash_and_equals
     - implicit_call_tearoffs
     - no_duplicate_case_values
     - only_throw_errors
+    - test_types_in_equals
     - throw_in_finally
     - type_annotate_public_apis
     - unawaited_futures

pkgs/dart_flutter_team_lints/pubspec.yaml

@@ -1,10 +1,10 @@
 name: dart_flutter_team_lints
 description: An analysis rule set used by the Dart and Flutter teams.
-version: 1.0.0
+version: 2.0.0
 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/dart_flutter_team_lints
 
 environment:
-  sdk: '>=2.19.0 <3.0.0'
+  sdk: ^3.0.0
 
 dependencies:
   lints: ^2.0.0

pkgs/firehose/lib/firehose.dart

@@ -7,10 +7,9 @@
 import 'dart:io';
 import 'dart:math';
 
-import 'package:firehose/src/repo.dart';
-
 import 'src/github.dart';
 import 'src/pub.dart';
+import 'src/repo.dart';
 import 'src/utils.dart';
 
 const String _botSuffix = '[bot]';

pkgs/firehose/lib/src/github.dart

@@ -6,10 +6,11 @@
 import 'dart:convert';
 import 'dart:io';
 
-import 'package:firehose/src/repo.dart';
 import 'package:http/http.dart' as http;
 import 'package:path/path.dart' as path;
 
+import 'repo.dart';
+
 // TODO:(devoncarew): Consider replacing some of this class with package:github.
 
 class Github {

pkgs/firehose/lib/src/health/health.dart

@@ -8,8 +8,8 @@ import 'dart:io';
 import 'dart:math';
 
 import 'package:collection/collection.dart';
-import 'package:firehose/firehose.dart';
 
+import '../../firehose.dart';
 import '../github.dart';
 import '../utils.dart';
 import 'changelog.dart';

pkgs/firehose/lib/src/repo.dart

@@ -4,11 +4,11 @@
 
 import 'dart:io';
 
-import 'package:firehose/src/changelog.dart';
 import 'package:path/path.dart' as path;
 import 'package:pubspec_parse/pubspec_parse.dart';
 import 'package:yaml/yaml.dart' as yaml;
 
+import 'changelog.dart';
 import 'github.dart';
 
 class Repository {

pkgs/repo_manage/lib/issue_transfer.dart

@@ -199,7 +199,7 @@ class TransferIssuesCommand extends ReportCommand {
       }
 
       print('Waiting a bit to allow Github to catch up...');
-      await Future<void>.delayed(Duration(seconds: 5));
+      await Future<void>.delayed(const Duration(seconds: 5));
     }
   }
 

pkgs/repo_manage/lib/weekly.dart

@@ -59,10 +59,10 @@ class WeeklyCommand extends ReportCommand {
         final now = DateTime.now();
         final currentDay = now.weekday;
         final thisWeek = now.subtract(Duration(days: currentDay - 1));
-        firstReportingDay = thisWeek.subtract(Duration(days: 7));
+        firstReportingDay = thisWeek.subtract(const Duration(days: 7));
       }
 
-      lastReportingDay = firstReportingDay.add(Duration(days: 6));
+      lastReportingDay = firstReportingDay.add(const Duration(days: 6));
     }
 
     var repos = noteableRepos.map(RepositorySlug.full).toList();