-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a health checking workflow #115
Conversation
PR HealthLicense Headers ✔️DetailsSome
Either manually or by running the following in your repository directory
Changelog entry ✔️DetailsChanges to these files need to be accounted for in their respective changelogs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts apart from what's in-line:
- I think it's worth having a 'health' check separate from the publishing one
- that's a good check to group a bunch a disparate items (changelog, copyright, ...)
Either manually or by running the following in your repository directory | ||
|
||
``` | ||
dart pub global activate --source git https://github.com/mosuem/file_licenser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonasfj - I remember that you were thinking of adding the ability to run packages directly (the context I remember this from was the flutter project template one). Something like dart pub run <package>:<tool>
would just run that tool w/o having to activate it locally first.
Bikeshedding on other possible PR comments: Licenses
All source files should start with a license header. Changelogs
Changes to files need to be accounted for in their respective changelogs. |
Merging #114 and #113 together with package validation to produce a single workflow.
It needs to be determined how this should behave w.r.t. publishing - do we want to keep a separate workflow for that? Should this be an argument to the
health.yaml
workflow?Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.