Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a health checking workflow #115

Merged
merged 49 commits into from
Jun 27, 2023
Merged

Introduce a health checking workflow #115

merged 49 commits into from
Jun 27, 2023

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jun 26, 2023

Merging #114 and #113 together with package validation to produce a single workflow.

It needs to be determined how this should behave w.r.t. publishing - do we want to keep a separate workflow for that? Should this be an argument to the health.yaml workflow?


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Jun 26, 2023
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

PR Health

License Headers ✔️

Details

Some .dart files were found to not have license headers. Please add the following header to all listed files:

// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files

Either manually or by running the following in your repository directory

dart pub global activate --source git https://github.com/mosuem/file_licenser
dart pub global run file_licenser .

Changelog entry ✔️

Details

Changes to these files need to be accounted for in their respective changelogs:

Package Files

@mosuem mosuem changed the title Unified workflow Introduce a health checking workflow Jun 26, 2023
@mosuem mosuem requested a review from devoncarew June 26, 2023 19:49
@mosuem mosuem marked this pull request as ready for review June 26, 2023 19:49
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts apart from what's in-line:

  • I think it's worth having a 'health' check separate from the publishing one
  • that's a good check to group a bunch a disparate items (changelog, copyright, ...)

.github/workflows/health.yaml Outdated Show resolved Hide resolved
.github/workflows/health.yaml Show resolved Hide resolved
.github/workflows/health.yaml Outdated Show resolved Hide resolved
.github/workflows/health.yaml Show resolved Hide resolved
pkgs/firehose/bin/firehose.dart Show resolved Hide resolved
tool/ci.sh Outdated Show resolved Hide resolved
Either manually or by running the following in your repository directory

```
dart pub global activate --source git https://github.com/mosuem/file_licenser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonasfj - I remember that you were thinking of adding the ability to run packages directly (the context I remember this from was the flutter project template one). Something like dart pub run <package>:<tool> would just run that tool w/o having to activate it locally first.

pkgs/firehose/lib/firehose.dart Outdated Show resolved Hide resolved
@devoncarew
Copy link
Member

Bikeshedding on other possible PR comments:


Licenses

☑️ File
pkgs/firehose/test/new_test.dart

All source files should start with a license header.

Changelogs

☑️ Package Changed Files
package:firehose pkgs/firehose/bin/firehose.dart, pkgs/firehose/lib/firehose.dart, pkgs/firehose/lib/src/github.dart, pkgs/firehose/pubspec.yaml, pkgs/firehose/test/new_test.dart

Changes to files need to be accounted for in their respective changelogs.

@mosuem mosuem merged commit 36c662e into main Jun 27, 2023
17 checks passed
@mosuem mosuem deleted the unifiedWorkflow branch June 27, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants