Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to the label normalization tool #151

Merged
merged 1 commit into from
Aug 22, 2023
Merged

updates to the label normalization tool #151

merged 1 commit into from
Aug 22, 2023

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Aug 22, 2023

Updates to the label normalization tool:

  • add a few more common labels synonyms (these help the tool know what to rename labels to)
  • add an alias for the --dry-run flag (--audit) and the --apply-changes flag (--apply)
  • increase the repo circuit breaker from 200 issues to 300 (this lets us manage slightly larger repos)

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

PR Health

Package publish validation ✔️

Details
Package Version Status
package:dart_flutter_team_lints 1.0.0 already published at pub.dev
package:firehose 0.3.24 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

@@ -216,7 +229,7 @@ class LabelsUpdateCommand extends ReportCommand {
print(' $slug has ${repo.openIssuesCount} issues and '
'${labels.length} labels.');

const circuitBreaker = 200;
const circuitBreaker = 300;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change accomplish? Can you include a bullet point about why this is changing in the commit message?

Copy link
Member Author

@devoncarew devoncarew Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup - this lets us work on slightly larger repos. This circuit breaker is here so that we don't make automated changes to the bigger repos w/o really thinking about it (w/o having to do something like edit the tool's source). I'll add a bullet-point.

@devoncarew devoncarew merged commit f777da7 into main Aug 22, 2023
@devoncarew devoncarew deleted the label_updates branch August 22, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants