Update health workflow #216

mosuem · 2024-01-04T10:59:14Z

Split health workflow into separate jobs
Make health workflow failure status configurable through fail_on and warn_on
Only test breaking changes for packages with changed files

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

github-actions · 2024-01-04T11:01:22Z

PR Health

Breaking changes ✔️

Details

Package	Change	Current Version	New Version	Needed Version	Looking good?
firehose	Breaking	0.4.2	0.5.0	0.5.0	✔️

Changelog Entry ✔️

Details

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details

File	Coverage
pkgs/firehose/bin/health.dart	💔 Not covered
pkgs/firehose/lib/src/github.dart	💔 61 % ⬇️ 12 %
pkgs/firehose/lib/src/health/health.dart	💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

License Headers ✔️

Details

// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details

Package	Version	Status
package:firehose	0.5.0	ready to publish
package:dart_flutter_team_lints	2.1.1	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions · 2024-01-05T11:54:23Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:firehose	0.5.0	ready to publish	`firehose-v0.5.0`
package:dart_flutter_team_lints	2.1.1	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

.github/workflows/health_base.yaml

.github/workflows/health_internal.yaml

.github/workflows/health_base.yaml

dcharkes

lgtm

pkgs/firehose/lib/src/health/health.dart

…, shelf, tools, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/9924570..e83d054): e83d054 2024-01-08 Futuristic Goo Fix typo (dart-archive/async#262) ecosystem (https://github.com/dart-lang/ecosystem/compare/dc44e82..1e2785d): 1e2785d 2024-01-09 Jacob MacDonald fix saving of comment ids to disk (dart-lang/ecosystem#221) 244a28d 2024-01-09 Moritz Update publish.yaml (dart-lang/ecosystem#217) bab9833 2024-01-09 Moritz Fix health commenting (dart-lang/ecosystem#219) f87e6f4 2024-01-08 Moritz Update health workflow (dart-lang/ecosystem#216) a58c7d8 2024-01-03 Moritz Fix `labeler.yml` (dart-lang/ecosystem#214) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/3d4c0d6..4a5b077): 4a5b077 2024-01-09 Polina Cherkasova Enhance scripting. (dart-lang/leak_tracker#204) e7094f4 2024-01-08 Polina Cherkasova Ignore test helpers. (dart-lang/leak_tracker#196) 6591934 2024-01-03 Polina Cherkasova Handle deprecation in Flutter. (dart-lang/leak_tracker#203) markdown (https://github.com/dart-lang/markdown/compare/d2e7903..7fdfa55): 7fdfa55 2024-01-01 dependabot[bot] Bump actions/stale from 8.0.0 to 9.0.0 (dart-lang/markdown#571) 5fab3a7 2023-12-19 Alex Li ✨ Introduce AlertBlockSyntax (dart-lang/markdown#570) native (https://github.com/dart-lang/native/compare/0605d9a..14f6da1): 14f6da1d 2024-01-09 Simon Binder Support `@Native` fields and `addressOf` (dart-lang/native#860) protobuf (https://github.com/dart-lang/protobuf/compare/20ec685..a293fb9): a293fb9 2024-01-08 Ömer Sinan Ağacan Handle deprecated options in grpc services and methods, enum types and values, messages (google/protobuf.dart#908) 9a408a7 2024-01-08 Ömer Sinan Ağacan Generate docs of enums and rpc clients, some refactoring (google/protobuf.dart#909) c4fd596 2024-01-06 Ömer Sinan Ağacan Export GeneratedMessageGenericExtensions in generated files (google/protobuf.dart#907) shelf (https://github.com/dart-lang/shelf/compare/733588f..823966f): 823966f 2024-01-03 Moritz Fix `labeler.yml` (dart-lang/shelf#403) tools (https://github.com/dart-lang/tools/compare/2f59ab4..8ffc077): 8ffc077 2024-01-03 Moritz Fix `labeler.yml` (dart-lang/tools#224) webdev (https://github.com/dart-lang/webdev/compare/b2405cb..c08a65c): c08a65c9 2024-01-09 Elliott Brooks Loosen `vm_service` constraints and prepare DWDS for release to 23.1.1 (dart-lang/webdev#2329) 651bdae6 2024-01-08 Derek Xu Make FrontendServerClient start the frontend server from AOT snapshot by default (dart-lang/webdev#2263) 4d1de266 2024-01-03 Elliott Brooks Prepare DWDS for release to version 23.1.0 (dart-lang/webdev#2328) Change-Id: I4d7fd994cc54ac2d72335c3ebf40710f3bd020e6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345366 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Update health workflow

41f8ca7

github-actions bot added the package:firehose label Jan 4, 2024

Add warn_on and fail_on

83c2789

github-actions bot added the type-infra A repository infrastructure change or enhancement label Jan 4, 2024

mosuem added 6 commits January 4, 2024 13:17

Change defaults

8450538

Refactorings

9b2e772

Change failure message

abc38a9

Write on failure

d208116

Test throw

be8d46a

Move comment Id saving up

fdae641

dart-lang deleted a comment from github-actions bot Jan 4, 2024

mosuem added 18 commits January 4, 2024 14:02

Fix line break

d1e27e3

Revert introducing error

babac7d

Append new workflows

c19d543

Fixes

a992afd

Add debug

b7c52eb

Fix name

6371dc0

Extract license wf

33f0446

Post summaries of license wf

0a22004

Refactor

1b5359c

Split into jobs

c0669d0

Separate jobs

4b35e55

Fix

585e0c4

Fix again

32caf70

Set version

8bf8c0f

Try again

ea12bb7

set fail

cda8c7f

Fix fail

f36ff91

Create folder

010b90d

mosuem added 11 commits January 5, 2024 11:50

Fix ref

6e04cac

Fix commenting

ecbc5fc

rename comments

85bf4a1

Fix merging

238e5b2

Remove empty

5a21dc9

Debug finding comment id

2e29e30

Fix

b55afb6

Always comment

797675d

Always upload comment

0a1a932

Fixes

f6180e1

Rename job

4fee5d3

dart-lang deleted a comment from github-actions bot Jan 5, 2024

mosuem added 4 commits January 5, 2024 12:45

Refactor to single check

aee37ad

Don't fail on changelog

7000934

Cleanups

4e84c0c

Add changelog

a5c3912

mosuem marked this pull request as ready for review January 5, 2024 12:00

mosuem requested review from devoncarew and dcharkes January 5, 2024 12:00

Remove names

ed74b97

dcharkes reviewed Jan 5, 2024

View reviewed changes

.github/workflows/health_base.yaml Outdated Show resolved Hide resolved

.github/workflows/health_internal.yaml Outdated Show resolved Hide resolved

.github/workflows/health_base.yaml Outdated Show resolved Hide resolved

.github/workflows/health_base.yaml Outdated Show resolved Hide resolved

mosuem added 2 commits January 5, 2024 14:30

Fix documentation

3e0fb4a

Add newlines

0e21976

dcharkes approved these changes Jan 5, 2024

View reviewed changes

pkgs/firehose/lib/src/health/health.dart Show resolved Hide resolved

mosuem merged commit f87e6f4 into main Jan 8, 2024
22 checks passed

mosuem deleted the healthUpdates branch January 8, 2024 13:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update health workflow #216

Update health workflow #216

mosuem commented Jan 4, 2024 •

edited

Loading

github-actions bot commented Jan 4, 2024 •

edited

Loading

github-actions bot commented Jan 5, 2024

dcharkes left a comment

Update health workflow #216

Update health workflow #216

Conversation

mosuem commented Jan 4, 2024 • edited Loading

github-actions bot commented Jan 4, 2024 • edited Loading

PR Health

Breaking changes ✔️

Changelog Entry ✔️

Coverage ⚠️

License Headers ✔️

Package publish validation ✔️

github-actions bot commented Jan 5, 2024

Package publishing

dcharkes left a comment

Choose a reason for hiding this comment

mosuem commented Jan 4, 2024 •

edited

Loading

github-actions bot commented Jan 4, 2024 •

edited

Loading