improvements for transferred issues

pkgs/sdk_triage_bot/lib/src/common.dart

@@ -37,9 +37,11 @@ String get geminiKey {
  return token;
 }
 
-/// Don't return more than 4k of text for an issue body.
+/// Don't return more than 5k of text for an issue body.
 String trimmedBody(String body) {
- return body.length > 4096 ? body = body.substring(0, 4096) : body;
+ const textLimit = 5 * 1024;
+
+ return body.length > textLimit ? body = body.substring(0, textLimit) : body;
 }
 
 class Logger {

pkgs/sdk_triage_bot/lib/src/github.dart

@@ -19,8 +19,15 @@ class GithubService {
  return result.map((item) => item.name).toList();
  }
 
- Future<Issue> fetchIssue(RepositorySlug sdkSlug, int issueNumber) async {
- return await _gitHub.issues.get(sdkSlug, issueNumber);
+ Future<Issue> fetchIssue(RepositorySlug slug, int issueNumber) async {
+ return await _gitHub.issues.get(slug, issueNumber);
+ }
+
+ Future<List<IssueComment>> fetchIssueComments(
+ RepositorySlug slug, Issue issue) async {
+ return await _gitHub.issues
+ .listCommentsByIssue(slug, issue.number)
+ .toList();
  }
 
  Future createComment(
@@ -145,3 +152,10 @@ GraphQLClient _initGraphQLClient() {
  link: auth.concat(HttpLink('https://api.github.com/graphql')),
  );
 }
+
+extension IssueExtension on Issue {
+ /// Returns whether this issue has any comments.
+ ///
+ /// Note that the original text for the issue is returned in the `body` field.
+ bool get hasComments => commentsCount > 0;
+}

pkgs/sdk_triage_bot/lib/src/prompts.dart

@@ -5,6 +5,7 @@
 String assignAreaPrompt({
  required String title,
  required String body,
+ String? lastComment,
 }) {
  return '''
 You are a software engineer on the Dart team at Google. You are responsible for
@@ -36,6 +37,7 @@ area-web: Use area-web for Dart web related issues, including the DDC and dart2j
 Don't make up a new area.
 Don't use more than one area- label.
 If it's not clear which area the issue should go in, don't apply an area- label.
+Take your time when considering which area to triage the issue into.
 
 If the issue is clearly a feature request, then also apply the label 'type-enhancement'.
 If the issue is clearly a bug report, then also apply the label 'type-bug'.
@@ -48,7 +50,10 @@ Issue follows:
 
 $title
 
-$body''';
+$body
+
+${lastComment ?? ''}'''
+ .trim();
 }
 
 String summarizeIssuePrompt({

pkgs/sdk_triage_bot/lib/triage.dart

@@ -46,6 +46,22 @@ Future<void> triage(
  }
  logger.log('');
 
+ // If the issue has any comments, retrieve and include the last comment in the
+ // prompt.
+ String? lastComment;
+ if (issue.hasComments) {
+ final comments = await githubService.fetchIssueComments(sdkSlug, issue);
+ final comment = comments.last;
+
+ lastComment = '''
+---
+
+Here is the last comment on the issue (by user @${comment.user?.login}):
+
+${trimmedBody(comment.body ?? '')}
+''';
+ }
+
  // decide if we should triage
  final alreadyTriaged = labels.any((l) => l.startsWith('area-'));
  if (alreadyTriaged && !force) {
@@ -76,7 +92,8 @@ Future<void> triage(
  try {
  // Failures here can include things like gemini safety issues, ...
  classification = await geminiService.classify(
- assignAreaPrompt(title: issue.title, body: bodyTrimmed),
+ assignAreaPrompt(
+ title: issue.title, body: bodyTrimmed, lastComment: lastComment),
  );
  } on GenerativeAIException catch (e) {
  stderr.writeln('gemini: $e');
@@ -121,7 +138,7 @@ Future<void> triage(
  logger.log('');
  logger.log('---');
  logger.log('');
- logger.log('Triaged ${issue.htmlUrl}.');
+ logger.log('Triaged ${issue.htmlUrl}');
 }
 
 List<String> filterExistingLabels(

pkgs/sdk_triage_bot/test/fakes.dart

@@ -29,6 +29,12 @@ class GithubServiceMock implements GithubService {
  return returnedIssue;
  }
 
+ @override
+ Future<List<IssueComment>> fetchIssueComments(
+ RepositorySlug slug, Issue issue) {
+ return Future.value([]);
+ }
+
  String? updatedComment;
 
  @override