Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a change policy for package:dart_flutter_team_lints #278

Merged
merged 4 commits into from
Jul 10, 2024
Merged

create a change policy for package:dart_flutter_team_lints #278

merged 4 commits into from
Jul 10, 2024

Conversation

devoncarew
Copy link
Member

  • create a change policy for package:dart_flutter_team_lints

This documents what our change policy currently effectively is; comments and additions welcome.

cc @natebosch @matanlurey @Piinks @goderbauer

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 3.1.0 3.1.1-wip 3.1.0 ✔️

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details 
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:dart_flutter_team_lints 3.1.1-wip WIP (no publish necessary)
package:firehose 0.9.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

goderbauer
goderbauer approved these changes Jul 10, 2024
View reviewed changes
Copy link

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devoncarew @kevmoo
Update pkgs/dart_flutter_team_lints/README.md
22d1b4f 
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
@devoncarew devoncarew merged commit 2635536 into main Jul 10, 2024
27 checks passed
@devoncarew devoncarew deleted the lint_change_policy branch July 10, 2024 21:29
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 15, 2024
@devoncarew
[deps] rev browser_launcher, cli_util, clock, dartdoc, ecosystem, htt…
59159d3 
…p, stack_trace, test, tools

Revisions updated by `dart tools/rev_sdk_deps.dart`.

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/6012690..fe7ffa1):
  fe7ffa1  2024-07-08  Kevin Moore  update lints (dart-archive/browser_launcher#62)

cli_util (https://github.com/dart-lang/cli_util/compare/6419270..6a0bb92):
  6a0bb92  2024-07-08  Kevin Moore  update lints (dart-archive/cli_util#106)

clock (https://github.com/dart-lang/clock/compare/ad428ea..6e43768):
  6e43768  2024-07-08  Kevin Moore  update lints (dart-archive/clock#68)
  b303a4b  2024-07-08  Kevin Moore  blast_repo fixes (dart-archive/clock#67)

dartdoc (https://github.com/dart-lang/dartdoc/compare/5e8de16..f6f93dd):
  f6f93ddf  2024-07-09  Sam Rawlins  Remove cross-export warning. (dart-lang/dartdoc#3523)
  9e86c9bf  2024-07-08  Sam Rawlins  Cache ModelElements for dynamic and Never (dart-lang/dartdoc#3815)
  eb04bf82  2024-07-08  Sam Rawlins  Bump to 8.0.11 (dart-lang/dartdoc#3817)
  6e3f1ace  2024-07-08  Sam Rawlins  Use the existing AnalysisContext in PackageBuilder (dart-lang/dartdoc#3814)

ecosystem (https://github.com/dart-lang/ecosystem/compare/4171189..2635536):
  2635536  2024-07-10  Devon Carew  create a change policy for package:dart_flutter_team_lints (dart-lang/ecosystem#278)

http (https://github.com/dart-lang/http/compare/4178b67..edbb5a9):
  edbb5a9  2024-07-12  Brian Quinlan  Add WebSocket usage examples to cupertino_http (dart-lang/http#1266)
  760564f  2024-07-11  Brian Quinlan  Prepare to publish cupertino_http 1.5.1 (dart-lang/http#1264)
  fd2c60e  2024-07-11  Brian Quinlan  Remove `runWithClient` Flutter example (dart-lang/http#1263)
  fece5b3  2024-07-11  Brian Quinlan  Document that widgets must be initialized before using the cronet_http (dart-lang/http#1262)
  3be8288  2024-07-11  Brian Quinlan  Prepare to publish cronet_http 1.3.2 (dart-lang/http#1265)
  068308b  2024-07-11  Hossein Yousefi  Upgrade jni and jnigen to 0.10.1 and 0.10.0 (dart-lang/http#1261)

stack_trace (https://github.com/dart-lang/stack_trace/compare/4fd3e2a..090d3d1):
  090d3d1  2024-07-08  Kevin Moore  update lints (dart-lang/stack_trace#157)

test (https://github.com/dart-lang/test/compare/14f9b3e..2c2ac49):
  2c2ac49d  2024-07-09  Nate Bosch  Expand error message for async test declaration (dart-lang/test#2251)

tools (https://github.com/dart-lang/tools/compare/43a8582..6a07a16):
  6a07a16  2024-07-08  Kevin Moore  update lints (dart-lang/tools#284)

Change-Id: I19ae934af5d9e5abf98537c4cb8fcd6288d0bc13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375740
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo left review comments

@natebosch natebosch natebosch approved these changes

@goderbauer goderbauer goderbauer approved these changes

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
package:dart_flutter_team_lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devoncarew @kevmoo @matanlurey @goderbauer @natebosch