update the prompt to include needs-info

[devoncarew]

• update the prompt to include triaging issues w/ needs-info labels
• [breaking change] issues should have breaking-change-request labels but don't necessarily need area labels
• add 5 'few-shot' examples in the classification prompt
• update benchmark expectations
• classification performance has generally improved from 56% to 65%

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[github-actions]

PR Health

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

File	Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Package	Version	Status
package:dart_flutter_team_lints	3.2.0	already published at pub.dev
package:firehose	0.9.2	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[lrhn]

How big do we expect the result to be? (Or rather, how many commas?)

This can do an extra string allocation per part, if the result text has space after commas.

Doing

  final labels = result.trim.split(_trimCommaRE).toList()..sort();
...

final _trimCommaRE = RegExp(r'\s*,\s*');

will still trim the outer string (but it's more likely to not have leading and trailing spaces, than commas are to not have surrounding space), and then remove spaces around commas while splitting.

(The sum of many small inefficiencies is a medium inefficiency that it's hard to find the source of. But ... this uses a RegExp, so now we have two problems 😉.)

[devoncarew]

:)

Thanks for the feedback; this will generally have either 0 or 1 commas. I think I'd prefer to avoid a regex for this bit of code.

[lrhn]

Tricky. I think we actually shouldn't add the tag.

Users can choose to write [breaking change], but that doesn't make it a breaking change request. Real breaking change requests come from the template, which should set labels too. That means that if the breaking-change-request label isn't already set, this is probably not a real breaking change request, just a user cargo-culting our process, and what they have is an enhancement request, likely one that does need an area.

[devoncarew]

I think I agree. I'll change this so the bot avoids triaging [breaking change] issues; manual review can figure out if they actually need any action.

[lrhn]

"Returns"

(A section starting with "Returns" is the recommended way to describe the returned value, just like a section starting with "The [foo] value ..." referencing a parameter is the recommended way to document that parameter.)

[devoncarew]

This is a directive to the LLM about what it should do, not describing what it will do. As in, "You should return the ...".

[lrhn]

(Feel free to ignore my performence comments. I just can't walk past an inefficient function. 😩)