Send a body on delete method

[lubritto]

The method http.delete just accept url and headers, can you put a body parameter ?

[natebosch]

A body isn't specifically disallowed by the spec but also has no specced semantics. I'm not sure if we'd add one or not.

What is the motivation?

[Henge9]

I would like to have the body in the DELETE method because people don't read the standard, and the standard is vague.

OpenAPI Specification ver. 2 in swagger allows it. (At least in javascript and go)

Its probably wrong but it works.

[rxwen]

+1

[ghost]

For reference, RFC 2616 doesn't mention much in connection with DELETE, but RFC 7231 has the following to say:

A payload within a DELETE request message has no defined semantics;
sending a payload body on a DELETE request might cause some existing
implementations to reject the request.

So while setting body on a DELETE request isn't strictly forbidden in the spec, it is discouraged.
Unless there is a really good use case for allowing it, it does not seem like a worthwhile investment to add it.
The fact that other libraries allow it in itself is not a persuasive argument.

[hacker1024]

Is it really our job to decide whether users are allowed to do things discouraged by the spec? A HTTP library should be able to do anything allowed by the spec, whether it's discouraged or not. This is a missing feature.

[thosakwe]

You can do this:

var rq = Request('DELETE', Uri.parse(...));
rq.bodyFields = {...};

var response = await client.send(rq).then(Response.fromStream);

It's not a "missing feature," IMO, because it's already supported. get, post, delete, etc. are just shorthand methods in the BaseClient class...

[quetool]

@thosakwe I am trying to implement your suggestion but it seems like I can not add headers parameters with that, is it possible?

[quetool]

I did it, I paste the code if it helps someone

(DELETE particular token from server)

http.Request rq = http.Request('DELETE', Uri.parse('${_getUrl()}/push.token'))
  ..headers.addAll({
    'Content-Type': 'application/x-www-form-urlencoded',
    'X-User-Id': _auth._id,
    'X-Auth-Token': _auth._token,
  });
rq.bodyFields = {
  'token': token,
};

http.StreamedResponse response = await http.Client().send(rq);

[devmvk]

Please add support for body parameter in http.delete method

[thosakwe]

I feel this would be trivial to send in a PR for.

On Sun, May 12, 2019 at 2:58 PM devmvk ***@***.***> wrote: Please add support for body parameter in http.delete method — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#206 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACMIUPF7L4MUFFSEAHACV3TPVBSEFANCNFSM4F2QRNPA> .

-- -- *Tobe Osakwe* Student, B.S. Comp. Sci, Florida State University https://thosakwe.com

[dfmiller]

Use case: Deleting a resource does not necessarily mean it is actually being deleted. It may be being marked deleted in the database and may require a reason for the deletion.

[DartMen]

Ive also encountered badly designed API's which needs payloads in DELETE methods and had to implement some boilerplate to make this work.

Would love to see an optional overridable method to feed a payload.

[danangponorogo]

Hi all, I've just found simple code to get call back value after delete with RESTful endpoint, still can't go with http.delete, but it can do RESTful delete as expected with id parameter on body. thanks to @quetool for the inspiration. Here's the code:

`// Flutter code

void deleteData() async {
http.Request rq = http.Request('DELETE', Uri.parse(widget.url));
rq.bodyFields = {
'id': widget.list[widget.index]['id'],
};
await http.Client().send(rq).then((response) {
response.stream.bytesToString().then((value) {
print(value); // it will print: {"status":"Success"}
});
Navigator.of(context).push(MaterialPageRoute(
builder: (BuildContext context) => Home(),
));
});
}`

`// PHP RESTfull code

function index_delete() // Delete
{
$id = $this->delete('id');
$delete = $this->model->delete($id);
if ($delete) {
$this->response(array('status' => 'Success'), 201);
} else {
$this->response(array('status' => 'Failed', 304));
}
}`

[cv-irvan]

I did it, I paste the code if it helps someone

(DELETE particular token from server)

http.Request rq = http.Request('DELETE', Uri.parse('${_getUrl()}/push.token'))
  ..headers.addAll({
    'Content-Type': 'application/x-www-form-urlencoded',
    'X-User-Id': _auth._id,
    'X-Auth-Token': _auth._token,
  });
rq.bodyFields = {
  'token': token,
};

http.StreamedResponse response = await http.Client().send(rq);

how to get the body from response?

[thosakwe]

@cv-irvan Look at the last line of my solution above. Basically, you use http.Response.fromStream() to convert a StreamedResponse into a Response. And then you can fetch the body or bodyBytes.