-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ok_http] Caching Configuration #1313
base: master
Are you sure you want to change the base?
Conversation
if (configuration.cacheSize != null) { | ||
_client = bindings.OkHttpClient_Builder.new() | ||
.cache(bindings.Cache.new1( | ||
bindings.File("".toJString()), configuration.cacheSize!)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Directory.systemTemp.createTemp().absolute.path
like package:cronet_http also doesn't help :(
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
Coverage
|
File | Coverage |
---|---|
pkgs/ok_http/example/lib/main.dart | 💔 Not covered |
pkgs/ok_http/lib/src/jni/bindings.dart | 💔 Not covered |
pkgs/ok_http/lib/src/ok_http_client.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
License Headers ⚠️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
pkgs/ok_http/lib/src/jni/bindings.dart |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/cronet_http/lib/src/jni/jni_bindings.dart |
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart |
pkgs/http/example/main.dart |
pkgs/http_client_conformance_tests/example/client_test.dart |
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart |
pkgs/http_client_conformance_tests/lib/src/multipart_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/multipart_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/redirect_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/redirect_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_body_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_body_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_headers_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_headers_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/request_methods_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/request_methods_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_body_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_body_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_headers_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_headers_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_web.dart |
pkgs/http_client_conformance_tests/lib/src/server_errors_server_vm.dart |
pkgs/http_client_conformance_tests/lib/src/server_errors_server_web.dart |
pkgs/http_profile/lib/http_profile.dart |
pkgs/java_http/lib/src/third_party/java/io/BufferedInputStream.dart |
pkgs/java_http/lib/src/third_party/java/io/InputStream.dart |
pkgs/java_http/lib/src/third_party/java/io/OutputStream.dart |
pkgs/java_http/lib/src/third_party/java/io/_package.dart |
pkgs/java_http/lib/src/third_party/java/lang/System.dart |
pkgs/java_http/lib/src/third_party/java/lang/_package.dart |
pkgs/java_http/lib/src/third_party/java/net/HttpURLConnection.dart |
pkgs/java_http/lib/src/third_party/java/net/URL.dart |
pkgs/java_http/lib/src/third_party/java/net/URLConnection.dart |
pkgs/java_http/lib/src/third_party/java/net/_package.dart |
pkgs/web_socket/example/web_socket_example.dart |
pkgs/web_socket/lib/testing.dart |
pkgs/web_socket_conformance_tests/example/client_test.dart |
pkgs/web_socket_conformance_tests/lib/src/close_local_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/close_local_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/echo_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/echo_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_web.dart |
pkgs/web_socket_conformance_tests/lib/src/protocol_server_vm.dart |
pkgs/web_socket_conformance_tests/lib/src/protocol_server_web.dart |
This check can be disabled by tagging the PR with skip-license-check
.
Items in this PR:
OkHttpClientConfiguration
to enable/disable cacheContribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.