Switch browser_client.dart to use fetch

[mraleph]

Rewrite browser_client.dart to use fetch instead of XHR.

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:http2	2.3.1	ready to publish	http2-v2.3.1
package:cronet_http	1.3.3-wip	WIP (no publish necessary)
package:cupertino_http	2.0.1	already published at pub.dev
package:http	1.3.0-wip	WIP (no publish necessary)
package:http_parser	4.1.1	already published at pub.dev
package:http_profile	0.1.1-wip	WIP (no publish necessary)
package:ok_http	0.1.1-wip	WIP (no publish necessary)
package:web_socket	0.1.6	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[github-actions]

PR Health

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
http	None	1.2.3-wip	1.3.0-wip	1.3.0-wip	✔️

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

File	Coverage
pkgs/http/lib/src/browser_client.dart	💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/cronet_http/lib/src/jni/jni_bindings.dart
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart
pkgs/http/example/main.dart
pkgs/http2/test/src/flowcontrol/mocks.mocks.dart
pkgs/http_client_conformance_tests/example/client_test.dart
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/compressed_response_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart
pkgs/http_client_conformance_tests/lib/src/multipart_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/multipart_server_web.dart
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/multiple_clients_server_web.dart
pkgs/http_client_conformance_tests/lib/src/redirect_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/redirect_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_body_streamed_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_cookies_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_headers_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_headers_server_web.dart
pkgs/http_client_conformance_tests/lib/src/request_methods_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/request_methods_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_body_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_body_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_body_streamed_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_cookies_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_headers_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_headers_server_web.dart
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/response_status_line_server_web.dart
pkgs/http_client_conformance_tests/lib/src/server_errors_server_vm.dart
pkgs/http_client_conformance_tests/lib/src/server_errors_server_web.dart
pkgs/http_parser/test/example_test.dart
pkgs/http_profile/lib/http_profile.dart
pkgs/ok_http/lib/src/jni/bindings.dart
pkgs/web_socket/example/web_socket_example.dart
pkgs/web_socket/lib/testing.dart
pkgs/web_socket_conformance_tests/example/client_test.dart
pkgs/web_socket_conformance_tests/lib/src/close_local_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/close_local_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/close_remote_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/continuously_writing_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/disconnect_after_upgrade_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/echo_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/echo_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/no_upgrade_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/peer_protocol_errors_server_web.dart
pkgs/web_socket_conformance_tests/lib/src/protocol_server_vm.dart
pkgs/web_socket_conformance_tests/lib/src/protocol_server_web.dart

[brianquinlan]

Nice!

There are some lints to fix here.
Do you want to increase the browser test coverage?
I also noticed that you aren't supporting streaming uploads - presumably that is because it is not well supported across browser versions?

[mraleph]

Fixing the lints now. I am a bit surprised that I don't get them in the IDE.

I also noticed that you aren't supporting streaming uploads - presumably that is because it is not well supported across browser versions?

Yeah, I am typing the comment on the issue now. tldr is that even when browser supports streaming request it can still refuse to do it if the server is not HTTP/2 or QUIC... Which means we can't really use it by default because it will potentially cause existing code to fail (even if we sniff browser compatibility - which by itself is a non-trivial thing to do :-/). I am honestly surprised how nasty browser implementation is - it does not even provide any useful information in the error message when this happens and you need to go look into the console to see ERR_H2_OR_QUIC_REQUIRED there.

[brianquinlan]

I want to be you when I grow up.

[mraleph]

I will wait landing this before we can get dev coverage. Don't want to land it with a broken CI.

Do you want to increase the browser test coverage?

Do you have something specific in mind?

I have tested firefox and safari locally and both work (though package:test is currently broken in different ways for these two browsers - -p firefox tries to use a binary which does not exist anymore and -p safari requires user intervention¹ to run tests).

Footnotes

1. I wasted couple of hours trying to come up with some way to launch and shutdown Safari cleanly after tests - but the only thing that really works requires using safaridriver. There is no clean equivalent to a simple "open target URL in new process" we get in other browsers. ↩

[brianquinlan]

I will wait landing this before we can get dev coverage. Don't want to land it with a broken CI.

Do you want to increase the browser test coverage?

Do you have something specific in mind?

I have tested firefox and safari locally and both work (though package:test is currently broken in different ways for these two browsers - -p firefox tries to use a binary which does not exist anymore and -p safari requires user intervention1 to run tests).

Yeah, that was what I was thinking - but I guess that won't work out right now. It looks like the checks are exceeding except for these tests:
https://github.com/dart-lang/http/actions/runs/11778289469/job/32896956901?pr=1401

Footnotes

1. I wasted couple of hours trying to come up with some way to launch and shutdown Safari cleanly after tests - but the only thing that really works requires using safaridriver. There is no clean equivalent to a simple "open target URL in new process" we get in other browsers. ↩

[mraleph]

I fixed 3.4 tests

[kevmoo]

What's the associated bug? Can resolve/close as well?

[jezell]

Thanks @mraleph! This is great.

I think reading request into memory still means it's going to blow up even when StreamedRequest could be streamed:

https://github.com/mraleph/http/blob/49f3b3cd83b38944722c2d4a1d60b70c1fb21eb9/pkgs/http/lib/src/browser_client.dart#L64

But, at least it puts the parts in place to enable some solutions to those problems.

Think what needs to be figured out is how do we get something other than a byte array to here:

https://github.com/mraleph/http/blob/49f3b3cd83b38944722c2d4a1d60b70c1fb21eb9/pkgs/http/lib/src/browser_client.dart#L71

Not sure the proper platform neutral abstraction for the library, but if there was a way to go something like:

import "package:http/web.dart";
import "package:web/web.dart" as web;

client.send(WebRequest(web.RequestBody));

RequestBody

At least that would provide some kind of path to do a file upload or manually pass a stream if you want.

[mraleph]

I am planning to look at request streaming as well, because I have already loaded the context into my head so it makes sense to do something before it gets paged out.