Prepare to publish null safe version #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mit-mit
reviewed
Nov 9, 2020
pubspec.yaml
Outdated
| @@ -1,15 +1,13 @@ | |||
| name: http | |||
| version: 0.13.0-nullsafety-dev | |||
| version: 0.13.0-nullsafety | |||
There was a problem hiding this comment.
I thought we recommended starting with -nullsafety.0 ?
There was a problem hiding this comment.
Either one is fine, good to have some consistency though and the .0 version makes it a bit more obvious how the versioning will be handled so that seems a bit better.
That is not the pattern we did originally, but I am in favor of making it the new pattern.
|
LGTE? (look good to everyone?) |
jakemac53
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.