Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Support WASM for package:intl" #823

Merged

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Apr 5, 2024

Relands #802.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:intl labels Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
intl Breaking 0.20.0-wip 0.20.0-wip 0.20.0-wip ✔️

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/intl/lib/find_locale.dart 💔 Not covered
pkgs/intl/lib/intl_browser.dart 💚 100 %
pkgs/intl/lib/src/http_request_data_reader.dart 💔 Not covered
pkgs/intl/lib/src/locale/locale_extensions.dart 💚 81 %
pkgs/intl/lib/src/locale/locale_implementation.dart 💚 85 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl4x 0.8.2 already published at pub.dev
package:intl_translation 0.20.0-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem requested a review from kevmoo April 5, 2024 09:38
Copy link
Contributor

@IchordeDionysos IchordeDionysos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌝

@copybara-service copybara-service bot merged commit fb36925 into main Apr 8, 2024
14 checks passed
@copybara-service copybara-service bot deleted the revert-822-revert-802-feat/intl-support-wasm branch April 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants