Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt package:messages to use dart:asset #843

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented May 27, 2024

This shows how to use hooks and dart:asset to store and retrieve messages.

It is experimental, and depends on https://dart-review.googlesource.com/c/sdk/+/351140 to land.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem changed the base branch from main to updateIntl4x May 27, 2024 11:13
@mosuem mosuem changed the base branch from updateIntl4x to main May 27, 2024 11:45
@dart-lang dart-lang deleted a comment from github-actions bot May 27, 2024
@mosuem mosuem changed the base branch from main to updateIntl4x May 27, 2024 11:48
Base automatically changed from updateIntl4x to main May 28, 2024 11:58
Copy link

github-actions bot commented May 28, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
messages Breaking 0.2.0 0.3.0-wip 0.3.0 ✔️
messages_builder Breaking 0.2.1 0.3.0-wip 0.3.0 ✔️
messages_serializer Non-Breaking 0.2.1 0.3.0-wip 0.2.2 ✔️

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/messages/example_json/bin/example.dart 💔 Not covered
pkgs/messages/example_json/hook/build.dart 💔 Not covered
pkgs/messages/lib/src/message.dart 💚 63 %
pkgs/messages/lib/src/plural_selector.dart 💔 Not covered
pkgs/messages_builder/lib/arb_parser.dart 💚 98 %
pkgs/messages_builder/lib/builder.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/class_generation.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/code.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/constructor_generation.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/field_generation.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/generation.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/import_generation.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/library_generation.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/method_generation.dart 💔 Not covered
pkgs/messages_builder/lib/generation_options.dart 💔 Not covered
pkgs/messages_builder/lib/hook.dart 💔 Not covered
pkgs/messages_builder/lib/message_with_metadata.dart 💚 70 %
pkgs/messages_serializer/lib/src/serializer.dart 💚 100 %
pkgs/messages_serializer/lib/src/serializer_json.dart 💚 94 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl4x 0.9.2-wip WIP (no publish necessary)
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.3.0-wip WIP (no publish necessary)
package:messages_builder 0.3.0-wip WIP (no publish necessary)
package:messages_serializer 0.3.0-wip WIP (no publish necessary)
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@dart-lang dart-lang deleted a comment from github-actions bot Jul 29, 2024
@mosuem mosuem changed the title Adapt the example in package:messages to use AssetBundle Adapt package:messages to use dart:asset Jul 29, 2024
@dart-lang dart-lang deleted a comment from github-actions bot Jul 30, 2024
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant