-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt package:messages
to use dart:asset
#843
base: main
Are you sure you want to change the base?
Conversation
f5a0922
to
dc27228
Compare
PR HealthBreaking changes ✔️Details
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. Coverage
|
File | Coverage |
---|---|
pkgs/messages/example_json/bin/example.dart | 💔 Not covered |
pkgs/messages/example_json/hook/build.dart | 💔 Not covered |
pkgs/messages/lib/src/message.dart | 💚 63 % |
pkgs/messages/lib/src/plural_selector.dart | 💔 Not covered |
pkgs/messages_builder/lib/arb_parser.dart | 💚 98 % |
pkgs/messages_builder/lib/builder.dart | 💔 Not covered |
pkgs/messages_builder/lib/code_generation/class_generation.dart | 💔 Not covered |
pkgs/messages_builder/lib/code_generation/code.dart | 💔 Not covered |
pkgs/messages_builder/lib/code_generation/constructor_generation.dart | 💔 Not covered |
pkgs/messages_builder/lib/code_generation/field_generation.dart | 💔 Not covered |
pkgs/messages_builder/lib/code_generation/generation.dart | 💔 Not covered |
pkgs/messages_builder/lib/code_generation/import_generation.dart | 💔 Not covered |
pkgs/messages_builder/lib/code_generation/library_generation.dart | 💔 Not covered |
pkgs/messages_builder/lib/code_generation/method_generation.dart | 💔 Not covered |
pkgs/messages_builder/lib/generation_options.dart | 💔 Not covered |
pkgs/messages_builder/lib/hook.dart | 💔 Not covered |
pkgs/messages_builder/lib/message_with_metadata.dart | 💚 70 % |
pkgs/messages_serializer/lib/src/serializer.dart | 💚 100 % |
pkgs/messages_serializer/lib/src/serializer_json.dart | 💚 94 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ✔️
Details
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Package publish validation ✔️
Details
Package | Version | Status |
---|---|---|
package:intl | 0.20.0-wip | WIP (no publish necessary) |
package:intl4x | 0.9.2-wip | WIP (no publish necessary) |
package:intl_translation | 0.20.1-wip | WIP (no publish necessary) |
package:messages | 0.3.0-wip | WIP (no publish necessary) |
package:messages_builder | 0.3.0-wip | WIP (no publish necessary) |
package:messages_serializer | 0.3.0-wip | WIP (no publish necessary) |
package:messages_shrinker | 0.2.2-wip | WIP (no publish necessary) |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
9a4d6ca
to
433d40d
Compare
433d40d
to
38ac02d
Compare
38ac02d
to
1dc22c0
Compare
package:messages
to use AssetBundle
package:messages
to use dart:asset
This shows how to use hooks and
dart:asset
to store and retrieve messages.It is experimental, and depends on https://dart-review.googlesource.com/c/sdk/+/351140 to land.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.