-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deferred loading messages #904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type-infra
A repository infrastructure change or enhancement
package:messages
package:messages_serializer
package:messages_builder
package:messages_shrinker
labels
Nov 5, 2024
mosuem
force-pushed
the
deferredLoadingMessages
branch
from
November 5, 2024 15:21
63d1b55
to
8789093
Compare
github-actions
bot
removed
type-infra
A repository infrastructure change or enhancement
package:messages_serializer
package:messages_shrinker
labels
Nov 5, 2024
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. |
devoncarew
approved these changes
Nov 11, 2024
pkgs/messages_builder/lib/code_generation/message_file_metadata.dart
Outdated
Show resolved
Hide resolved
pkgs/messages_builder/lib/code_generation/message_file_metadata.dart
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
type-infra
A repository infrastructure change or enhancement
label
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package:messages_builder
package:messages
type-infra
A repository infrastructure change or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deferred components to the Flutter example. This allows to load message files on demand from the Play Store.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.