Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred loading messages #904

Merged
merged 14 commits into from
Nov 13, 2024
Merged

Deferred loading messages #904

merged 14 commits into from
Nov 13, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Nov 5, 2024

Add deferred components to the Flutter example. This allows to load message files on demand from the Play Store.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot removed type-infra A repository infrastructure change or enhancement package:messages_serializer package:messages_shrinker labels Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem mosuem marked this pull request as ready for review November 11, 2024 15:40
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Nov 13, 2024
@mosuem mosuem merged commit dff57eb into main Nov 13, 2024
13 checks passed
@mosuem mosuem deleted the deferredLoadingMessages branch November 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:messages_builder package:messages type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants