Reorder the sections in the macros proposal. #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the diff of this is a nightmare, I have made no substantial changes. All I did was reorganize the existing sections and add some TODOs for parts to fill in. This means the resulting prose doesn't flow and is weird in some places. I'll fix that in follow up PRs, but I wanted to do the reordering separately since the diff is unreadable. I also removed the TOC from the top since GitHub generates one automatically: isaacs/github#215 (comment)
jakemac53
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the diff of this is a nightmare, I have made no substantial
changes. All I did was reorganize the existing sections and add some
TODOs for parts to fill in. This means the resulting prose doesn't
flow and is weird in some places. I'll fix that in follow up PRs, but
I wanted to do the reordering separately since the diff is unreadable.
I also removed the TOC from the top since GitHub generates one
automatically: isaacs/github#215 (comment)