Skip to content

clarify identifier scope, allow bare Identifiers, allow Lists and Maps #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 8, 2022

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Feb 4, 2022

Attempt to close #2093, and #2092. Related to #2012.

  • Adds Identifier, List, and Map as valid parameter types for macro constructors (and thus valid arguments for macro applications).
    • List and Map are allowed to have type arguments that are any of the supported types. This allows for List<Identifier>, etc.
  • Specify the scope for identifiers in macro application arguments better (both bare and in code objects).
  • Some other unrelated cleanup (can remove if desired).
    • Fixed up some old links
    • Removed the section on Fragment (you can just use Code for this now).

@jakemac53 jakemac53 merged commit 8a24ca8 into master Feb 8, 2022
@jakemac53 jakemac53 deleted the allow-identifiers-and-generic-collections branch February 8, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How are macros passed names of declarations to produce?
3 participants