Specify errors about wrong import augment/import structures
#3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
changed the title
import augment graphs, and an error about wrong uris in import augment directivesimport augment/import structures
munificent
approved these changes
Mar 27, 2024
|
Thanks! I made some adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the response in #3646, this PR specifies a compile-time error which occurs if a main library L which is being augmented along with all augmentation libraries A1 .. Ak reachable from L via one or more
import augmentlinks forms a graph that has a cycle.This PR also makes it an error for a
<uri>in animport augmentdirective to denote a regular library, it must be an augmentation library. This change is also based on #3646.Finally, this PR makes it an error for a
<uri>in a regularimportdirective (notimport augment) to denote an entity which is not a library (including: it's an error if it is an augmentation library).