Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in Static shorthand proposal #4229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Jan 13, 2025

  • <selector*> changed to <selector>*
  • Duplication in "Expressions of the forms .new<typeArgs> or .new<typeArgs>..." changed to "Expressions of the forms .new<typeArgs> or .new<typeArgs>(args)..."
  • "... or a pattern has the form == e2..." added "or != e2"
  • accidental character removed
  • staticIdentifierShorthandHead -> staticMemberShorthandHead

production, or the entire chain) are compile-time errors, just like
the corresponding <code>*T*.new\<*typeArgs*\></code>
and <code>*T*.new\<*typeArgs*\></code> already are, whether used as instantiated
tear-off or invoked.
and <code>*T*.new\<*typeArgs*\>(*args*)</code> already are, whether used as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the original code is what @lrhn intended here, but I'm not sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code looks like "Expressions of the forms .new<typeArgs> or .new<typeArgs>...just like the corresponding T.new<typeArgs> and T.new<typeArgs>...".

(T).new<typeArgs> is repeated twice. I believe that the second one was intended to have an arguments part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants