Recommend to opt out hacky tests on the page that is linked in leak tracking error. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
reviewed
Sep 26, 2024
| @@ -69,7 +69,16 @@ to happen after the rendering cycle completes. | |||
| If this is a case, `imageCache.clear()` needs to happen as last statement of the test, | |||
| instead of in tear down, to allow the cycles to happen. | |||
|
|
|||
| ### 4. The test throws flutter exception | |||
| ### 4. The test is hacky | |||
There was a problem hiding this comment.
Following up on request from flutter/flutter#154481
IMO, hacky tests should generally be avoided. :)
Does this scenario need to be documented then? It feels like a blank check that anyone could say, well let's just skip testing for leaks since this test is a hack. That feels like a test that is not very valuable.
There was a problem hiding this comment.
Yes, we want to avoid hacky tests as much as possible.
But, some tests have to be hacky.
So I suggest the rule like "To opt out a test, prove carefully that the test is hacky".
But, yes, we can skip documenting this to reduce tendency to opt out tests.
polina-c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.